Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Reinstate ES5 build transpiling #329

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Conversation

robmorieson
Copy link
Contributor

What does this PR introduce?

  • Updates the .babelrc to target the last 2 browser version during build
  • Bumps node to latest LTS now that 16 has reached EOL

Related issues

@robmorieson robmorieson added the bug Something isn't working label Oct 13, 2023
@robmorieson robmorieson self-assigned this Oct 13, 2023
@vercel
Copy link

vercel bot commented Oct 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-live-chat-loader ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 13, 2023 0:52am

@robmorieson robmorieson merged commit 8c1082e into main Oct 13, 2023
@robmorieson robmorieson deleted the bugfix-228-es5-transpiling branch October 13, 2023 02:25
@altaywtf
Copy link
Contributor

altaywtf commented Nov 18, 2023

btw just upgraded library but unfortunately this PR only fixes cjs. people using esm would still have the problem.

I think you missed this line: https://github.com/calibreapp/react-live-chat-loader/blob/main/.babelrc#L39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

[Bug] dist bundle no longer transpiled to es5
3 participants