Update module target in .babelrc
#341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
|
@altaywtf thanks for spotting the bug and rolling out a fix: very much appreciated 🙌 Re. the additional points: would you be happy to include them in this PR? |
|
sure thing, all good for me! -- done! ⬇️ |
robmorieson
approved these changes
Nov 27, 2023
|
🎉 🎉 😅 looking forward to eliminating one more line here: // webpack.common.js
exclude: createTranspileDependencies([
'react-live-chat-loader',
'p-timeout',
'p-min-delay',
]), |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a tiny PR to fix #329 (comment).
btw you don't need
@babel/plugin-proposal-class-propertiesand@babel/plugin-proposal-object-rest-spreadbecause they're are merged intopreset-env.you're also using
nullish coalescing operatorbut didn't have to add a transform for that, guess why? because it's also a part of thepreset-env: https://babeljs.io/docs/babel-plugin-transform-nullish-coalescing-operator 😇👍