fix: [email protected] #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is that also compatible with 8.5.2? |
|
Yes no changes where made to the |
BobdenOs
requested review from
danjoa,
johannes-vogel and
stewsk
as code owners
johannes-vogel
approved these changes
Sep 5, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[email protected]includes an upgrade ofsqlite3which contains a performance optimization forjsonfunctions (changelog)The performance optimization seems to take the trade of that it uses more memory. Which made the
lean-drafttests run intoSQLITE_NOMEM(out of memory) errors. After some investigating this seems to be related to the solution used to support 50+ columns in select statements. This PR switches to usejson_patchwhich is equal toObject.assign({...},{...}). Which seems to make the behavior as expected again. Might even be a small general performance increase.