From 21f2af2e819a1b9c375285641d6d4f7cd20645fa Mon Sep 17 00:00:00 2001
From: D070615 <olena.timrova@sap.com>
Date: Tue, 13 Feb 2024 14:57:29 +0100
Subject: [PATCH 1/2] fix INSERT entries containing undefined values

---
 db-service/lib/cqn2sql.js                          |  3 ++-
 .../db/basic/literals/basic.literals.string.js     | 14 ++++++++++++++
 2 files changed, 16 insertions(+), 1 deletion(-)

diff --git a/db-service/lib/cqn2sql.js b/db-service/lib/cqn2sql.js
index 2db22e7e1..ef2a16f90 100644
--- a/db-service/lib/cqn2sql.js
+++ b/db-service/lib/cqn2sql.js
@@ -479,10 +479,11 @@ class CQN2SQLRenderer {
 
           buffer += '"'
         } else {
+          if (val === undefined) continue
           if (elements[key]?.type in BINARY_TYPES) {
             val = transformBase64(val)
           }
-          buffer += `${keyJSON}${val === undefined ? 'null' : JSON.stringify(val)}`
+           buffer += `${keyJSON}${JSON.stringify(val)}`
         }
       }
       buffer += '}'
diff --git a/test/compliance/resources/db/basic/literals/basic.literals.string.js b/test/compliance/resources/db/basic/literals/basic.literals.string.js
index 0888d5264..227bb933f 100644
--- a/test/compliance/resources/db/basic/literals/basic.literals.string.js
+++ b/test/compliance/resources/db/basic/literals/basic.literals.string.js
@@ -11,6 +11,20 @@ module.exports = [
     large: null,
     blob: null,
   },
+  {
+    string: undefined,
+    char: undefined,
+    short: undefined,
+    medium: undefined,
+    large: undefined,
+    blob: undefined,
+    '=string': null,
+    '=char': null,
+    '=short': null,
+    '=medium': null,
+    '=large': null,
+    '=blob': null,
+  },
   {
     string: 'Simple String',
   },

From 6bff7fc08e714dbedc55607deffa748b4cadb0ad Mon Sep 17 00:00:00 2001
From: Olena <etimryaka@gmail.com>
Date: Tue, 13 Feb 2024 15:08:32 +0100
Subject: [PATCH 2/2] Update db-service/lib/cqn2sql.js

Co-authored-by: Bob den Os <108393871+BobdenOs@users.noreply.github.com>
---
 db-service/lib/cqn2sql.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/db-service/lib/cqn2sql.js b/db-service/lib/cqn2sql.js
index ef2a16f90..151ff087d 100644
--- a/db-service/lib/cqn2sql.js
+++ b/db-service/lib/cqn2sql.js
@@ -483,7 +483,7 @@ class CQN2SQLRenderer {
           if (elements[key]?.type in BINARY_TYPES) {
             val = transformBase64(val)
           }
-           buffer += `${keyJSON}${JSON.stringify(val)}`
+          buffer += `${keyJSON}${JSON.stringify(val)}`
         }
       }
       buffer += '}'