-
Notifications
You must be signed in to change notification settings - Fork 53
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #362 from carvel-dev/force-basic-auth
Force basic auth via flag
- Loading branch information
Showing
3 changed files
with
147 additions
and
29 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,94 @@ | ||
| // Copyright 2023 VMware, Inc. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| package git_test | ||
|
|
||
| import ( | ||
| "os" | ||
| "strings" | ||
| "testing" | ||
|
|
||
| "carvel.dev/vendir/pkg/vendir/config" | ||
| "carvel.dev/vendir/pkg/vendir/fetch" | ||
| "carvel.dev/vendir/pkg/vendir/fetch/git" | ||
| "github.com/stretchr/testify/require" | ||
| ) | ||
|
|
||
| func TestGit_Retrieve(t *testing.T) { | ||
| t.Run("Force basic auth header when flag is enabled and the user/pass is provided", func(t *testing.T) { | ||
| secretFetcher := &fetch.SingleSecretRefFetcher{Secret: &config.Secret{ | ||
| Metadata: config.GenericMetadata{ | ||
| Name: "some-secret", | ||
| }, | ||
| Data: map[string][]byte{ | ||
| "username": []byte("YWRtaW4="), // admin | ||
| "password": []byte("cGFzc3dvcmQ="), // password | ||
| }, | ||
| }} | ||
| runner := &cmdRunnerLocal{commandsToRun: [][]string{}} | ||
| gitRetriever := git.NewGitWithRunner(config.DirectoryContentsGit{ | ||
| URL: "https://some.git/repo", | ||
| Ref: "origin/main", | ||
| SecretRef: &config.DirectoryContentsLocalRef{Name: "some-secret"}, | ||
| ForceHTTPBasicAuth: true, | ||
| }, os.Stdout, secretFetcher, runner) | ||
| _, err := gitRetriever.Retrieve("", &tmpFolder{t}) | ||
| require.NoError(t, err) | ||
| isPresent := false | ||
| // Check that the header was added with the correct values | ||
| for _, args := range runner.commandsToRun { | ||
| if args[0] == "config" && args[1] == "--add" { | ||
| isPresent = true | ||
| require.Equal(t, "config --add http.extraHeader Authorization: Basic WVdSdGFXND06Y0dGemMzZHZjbVE9", strings.Join(args, " ")) | ||
| } | ||
| } | ||
| require.True(t, isPresent, "could not find the configuration") | ||
| }) | ||
|
|
||
| t.Run("Errors when authenticating with user/pass on http URL", func(t *testing.T) { | ||
| secretFetcher := &fetch.SingleSecretRefFetcher{Secret: &config.Secret{ | ||
| Metadata: config.GenericMetadata{ | ||
| Name: "some-secret", | ||
| }, | ||
| Data: map[string][]byte{ | ||
| "username": []byte("YWRtaW4="), // admin | ||
| "password": []byte("cGFzc3dvcmQ="), // password | ||
| }, | ||
| }} | ||
| runner := &cmdRunnerLocal{commandsToRun: [][]string{}} | ||
| gitRetriever := git.NewGitWithRunner(config.DirectoryContentsGit{ | ||
| URL: "http://some.git/repo", | ||
| Ref: "origin/main", | ||
| SecretRef: &config.DirectoryContentsLocalRef{Name: "some-secret"}, | ||
| ForceHTTPBasicAuth: true, | ||
| }, os.Stdout, secretFetcher, runner) | ||
| _, err := gitRetriever.Retrieve("", &tmpFolder{t}) | ||
| require.ErrorContains(t, err, "Username/password authentication is only supported for https remotes") | ||
| }) | ||
| } | ||
|
|
||
| type cmdRunnerLocal struct { | ||
| commandsToRun [][]string | ||
| } | ||
|
|
||
| func (c *cmdRunnerLocal) RunMultiple(argss [][]string, _ []string, _ string) error { | ||
| c.commandsToRun = append(c.commandsToRun, argss...) | ||
| return nil | ||
| } | ||
|
|
||
| func (c *cmdRunnerLocal) Run(args []string, _ []string, _ string) (string, string, error) { | ||
| c.commandsToRun = append(c.commandsToRun, args) | ||
| return "", "", nil | ||
| } | ||
|
|
||
| type tmpFolder struct { | ||
| t *testing.T | ||
| } | ||
|
|
||
| func (t tmpFolder) NewTempDir(_ string) (string, error) { | ||
| return t.t.TempDir(), nil | ||
| } | ||
|
|
||
| func (t tmpFolder) NewTempFile(_ string) (*os.File, error) { | ||
| panic("Not implemented") | ||
| } |