Fixed Github Actions workflows #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atillack
approved these changes
Feb 4, 2025
rwxayheee
reviewed
Feb 4, 2025
| @@ -75,24 +79,32 @@ jobs: | |||
| sed -i s/^mirrorlist=http/#mirrorlist=http/g /etc/yum.repos.d/*.repo | |||
There was a problem hiding this comment.
These sed commands were added to enforce a working config when we had runners still using CentOS 7 after it reached end of life. Feel free to discard if they're causing problems in the future. Thanks again for the work done
There was a problem hiding this comment.
That workflow still uses Centos and it's a pain. It probably has to be rewritten.
There was a problem hiding this comment.
Is there a way to request Ubuntu?
There was a problem hiding this comment.
No worries at the moment. If it's currently working we can keep it as it is
There was a problem hiding this comment.
Yes, it is possible. The job below uses Ubuntu (I'm guessing it was written later?). But yeah, we can upgrade later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the workflows in the github actions folder. Now the code should automatically compile and upload to pypi on release. This included: