Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why does celery pin 4.4.0 as the upper limit of redis? #8216

Closed
baseplate-admin opened this issue Apr 26, 2023 · 9 comments
Closed

Why does celery pin 4.4.0 as the upper limit of redis? #8216

baseplate-admin opened this issue Apr 26, 2023 · 9 comments
Milestone

Comments

@baseplate-admin
Copy link

Hi Thanks for creating Celery. Its one of the best python queue management solution.

redis>=4.3.6,<4.4.0

so it seems that celery pins 4.4.0 as the upper limit.

Which raises this CVE

image

is there any particular reason for this upper pin?

@open-collective-bot
Copy link

Hey @baseplate-admin 👋,
Thank you for opening an issue. We will get back to you as soon as we can.
Also, check out our Open Collective and consider backing us - every little helps!

We also offer priority support for our sponsors.
If you require immediate assistance please consider sponsoring us.

@auvipy
Copy link
Member

auvipy commented Apr 26, 2023

  1. this is a false positive CVE as celery use python 3.7+
  2. upgrading version cause atleast one test to fail iin kombu.

@sr-verde
Copy link

Can you please tell me why Python 3.7+ should fix this problem? I haven't found a reason.

@auvipy
Copy link
Member

auvipy commented Apr 27, 2023

I learnt that from redis-py maintainers

@sr-verde
Copy link

Thanks for your fast answer but that sounds like "trust me bro". Is there any public source for this information? 😬

@auvipy
Copy link
Member

auvipy commented Apr 28, 2023

redis/redis-py#2672 and I am open to contribution to upgrade the version! trust me bro! :D

@eukreign
Copy link

This constraint makes celery[redis] unuseable/conflict with the latest django channels-redis:

The conflict is caused by:
    celery[redis] 5.3.0b2 depends on redis<4.4.0 and >=4.2.2; extra == "redis"
    channels-redis 4.1.0 depends on redis>=4.5.3

django/channels_redis@dbf4f30

@auvipy
Copy link
Member

auvipy commented Apr 30, 2023

contributions are welcome

@auvipy
Copy link
Member

auvipy commented May 31, 2023

its fixed in main branch now

@auvipy auvipy closed this as completed May 31, 2023
@auvipy auvipy added this to the 5.3 milestone May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants