Feat: add passthrough to genesis #1888

mustermeiszer · 2024-06-26T12:58:54Z

Description

Currently, we always need to have real Axelar routers on testnets. That prevents us from texting LP logic on development for example.

This PR adds a passthrough router on the EVM side to all new chains. The router always sits at the same location (0x33e7daf228e7613ba85ef6c3647dbceb0f011f7c) and is based on this contract.

The router simply forwards LP messages to the precompile, without checking anything. The AxelarPrecompile of course needs to have 0x33e7daf228e7613ba85ef6c3647dbceb0f011f7c set as its trusted GatewayContract.

Feat

Enables testing LP logic on development - making development our main testground and demo will move more to a public testground for external users

Changes and Descriptions

Adds runtime_common::evm::utils::account_codes() - generates the genesis codes for the EVM side
Adds passthrough router bytecode as constant
Adds passthrough router H160 by deriving a hash from a constant input

Checklist:

I have added Rust doc comments to structs, enums, traits and functions
I have made corresponding changes to the documentation
I have performed a self-review of my code
I have added tests that prove my fix is effective or that my feature works

wischli

Great improvement!

wischli · 2024-06-26T13:11:19Z

runtime/common/src/evm/mod.rs

@@ -107,3 +107,55 @@ impl<T: pallet_aura::Config<AuthorityId = AuraId>> FindAuthor<H160> for FindAuth
 		None
 	}
 }
+
+/// Passthrough router deployed bytecode as of this state https://github.com/centrifuge/liquidity-pools/tree/d3da102e7bf656fd50feeb888e17f423317aeeb3


Q: Which code changes on solidity side lead to a required update of the bytecode?

Just the ones in the file linked above. Should maybe make that clear in the comment.

lemunozm

LGTM! This change does not imply any change/simplification in the current lp tests?

lemunozm · 2024-06-26T15:42:16Z

node/src/chain_spec.rs

@@ -352,7 +352,7 @@ fn centrifuge_genesis(
 			"chainId": Into::<u32>::into(chain_id),
 		},
 		"evm": {
-			"accounts": runtime_common::evm::precompile::utils::precompile_account_genesis::<centrifuge_runtime::Precompiles>(),
+			"accounts": runtime_common::evm::utils::account_genesis::<centrifuge_runtime::Precompiles>(),


Do we also change this for testing purposes right?

@wischli we should probably also generate a new dev genesis, right? For the life environment, or don't we use a static one?

…er-in-genesis

lemunozm

LGTM

lemunozm · 2024-07-24T12:24:22Z

runtime/common/src/evm/mod.rs

+	b"PASSTHROUGH_ROUTER_ACCOUNT_CODES_ACCOUNT_LOCATION_SALT";
+
+pub fn passthrough_router_location() -> H160 {
+	H160::from(sp_core::H256::from(sp_core::KeccakHasher::hash(


Curious, who demands the usage of KeccakHasher?

That is just the natural derivation scheme vor evm addresses.

wischli · 2024-07-24T20:13:44Z

@mustermeiszer Sorry for being intrusive. I can imagine you have tons of stuff on your plate before holiday so I made some minor changes to make CI green.

wischli · 2024-07-25T08:41:27Z

runtime/common/src/evm/mod.rs

+			BlakeTwo256::hash_of(&PASSTHROUGH_ROUTER_ACCOUNT_CODES.to_vec()),
+			hex_literal::hex!("545a48d6f7f1a01cb2bd090a5272cd52c54eafea762071ec652c8ac94610146e")


@mustermeiszer This test fails. I suppose due to changes to the PassThroughAdapter.sol between your referenced commit ee35da785f2af3303ef9f52c6ecefeb9671aa61b and current main at 223a0f36edabc675f8c74c47b20e366178df7ca3, see diff.

I wonder how you derived the passthrough account byte codes.

Error

thread 'evm::tests::stable_passthrough_bytecode_hash' panicked at runtime/common/src/evm/mod.rs:160:9: assertion `left == right` failed left: 0x31173f15567854cfc3702aa6b639bf0dedf74638e745a3e90fa00f1619d8b94c right: 0x545a48d6f7f1a01cb2bd090a5272cd52c54eafea762071ec652c8ac94610146e

As I can not compile it wanted to retrieve the new hash through the UI. Haha. So using the hash here generated will be okay

But how can I derive the PASSTHROUGH_ROUTER_ACCOUNT_CODES?

You just need to swap the hashes

But then I only adjust the blake2 256 hash of the PASSTHROUGH_ROUTER_ACCOUNT_CODES but not any of the 3289 bytes of PASSTHROUGH_ROUTER_ACCOUNT_CODES. Based on your comments, those need to be adjusted as well?

/// Passthrough router deployed bytecode as of this state https://github.com/centrifuge/liquidity-pools/blob/ee35da785f2af3303ef9f52c6ecefeb9671aa61b/test/integration/PassthroughAdapter.sol /// /// NOTE: If the above file changes, this code needs to be adapted. ...

Does this change logically suffice @mustermeiszer ? 949bdff Technically, it fixes tests.

Yes, that was, what I intended to do! Perfect! We always need that hash for setting up the routers, so I wanted to have it somewhere ^^

…er-in-genesis

codecov · 2024-07-25T14:46:53Z

Codecov Report

Attention: Patch coverage is 11.11111% with 16 lines in your changes missing coverage. Please review.

Project coverage is 47.95%. Comparing base (8e714b8) to head (837006f).

Files	Patch %	Lines
runtime/common/src/evm/mod.rs	13.33%	13 Missing ⚠️
node/src/chain_spec.rs	0.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1888      +/-   ##
==========================================
- Coverage   48.02%   47.95%   -0.07%     
==========================================
  Files         181      181              
  Lines       13144    13159      +15     
==========================================
- Hits         6313     6311       -2     
- Misses       6831     6848      +17

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* feat: add passthrough to genesis * fix: adapt passthrough router * fix: docs and hash * chore: rm unused test * feat: adatpt to latest version * fix: array size * fix: clippy + fmt * fix: update blake hash * fix: compilation * fix: std import KeccakHasher --------- Co-authored-by: William Freudenberger <[email protected]>

feat: add passthrough to genesis

4deb648

mustermeiszer requested review from lemunozm, cdamian and wischli June 26, 2024 12:58

wischli previously approved these changes Jun 26, 2024

View reviewed changes

lemunozm previously approved these changes Jun 26, 2024

View reviewed changes

fix: adapt passthrough router

1afd37b

mustermeiszer dismissed stale reviews from lemunozm and wischli via 1afd37b June 26, 2024 18:40

mustermeiszer added 7 commits June 26, 2024 22:00

fix: docs and hash

b7bf2ac

chore: rm unused test

e27a364

Merge remote-tracking branch 'origin/main' into feat/passthrough-rout…

5b12a73

…er-in-genesis

feat: adatpt to latest version

8811f60

Merge branch 'main' into feat/passthrough-router-in-genesis

39b0cc8

Merge branch 'main' into feat/passthrough-router-in-genesis

2ee36b8

fix: array size

ab2b1f4

lemunozm previously approved these changes Jul 24, 2024

View reviewed changes

fix: clippy + fmt

6a03f9f

wischli dismissed lemunozm’s stale review via 6a03f9f July 24, 2024 20:12

lemunozm previously approved these changes Jul 24, 2024

View reviewed changes

wischli reviewed Jul 25, 2024

View reviewed changes

fix: update blake hash

949bdff

wischli dismissed lemunozm’s stale review via 949bdff July 25, 2024 09:36

wischli added 2 commits July 25, 2024 13:47

fix: compilation

7451360

Merge remote-tracking branch 'origin/main' into feat/passthrough-rout…

be077a1

…er-in-genesis

wischli requested a review from hieronx as a code owner July 25, 2024 11:47

fix: std import KeccakHasher

837006f

wischli approved these changes Jul 25, 2024

View reviewed changes

wischli merged commit f5ce924 into main Jul 25, 2024
12 checks passed

wischli deleted the feat/passthrough-router-in-genesis branch July 25, 2024 14:56

wischli mentioned this pull request Jul 30, 2024

lp-v2: fix message fields #1933

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat: add passthrough to genesis #1888

Feat: add passthrough to genesis #1888

mustermeiszer commented Jun 26, 2024

wischli left a comment

wischli Jun 26, 2024

mustermeiszer Jun 26, 2024

lemunozm left a comment

lemunozm Jun 26, 2024

mustermeiszer Jun 26, 2024

mustermeiszer Jun 26, 2024

lemunozm left a comment

lemunozm Jul 24, 2024

mustermeiszer Jul 24, 2024

wischli commented Jul 24, 2024

wischli Jul 25, 2024

mustermeiszer Jul 25, 2024

wischli Jul 25, 2024

mustermeiszer Jul 25, 2024

wischli Jul 25, 2024

wischli Jul 25, 2024 •

edited

Loading

mustermeiszer Jul 25, 2024

codecov bot commented Jul 25, 2024

		BlakeTwo256::hash_of(&PASSTHROUGH_ROUTER_ACCOUNT_CODES.to_vec()),
		hex_literal::hex!("545a48d6f7f1a01cb2bd090a5272cd52c54eafea762071ec652c8ac94610146e")

Feat: add passthrough to genesis #1888

Feat: add passthrough to genesis #1888

Conversation

mustermeiszer commented Jun 26, 2024

Description

Feat

Changes and Descriptions

Checklist:

wischli left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lemunozm left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lemunozm left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wischli commented Jul 24, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wischli Jul 25, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Jul 25, 2024

Codecov Report

wischli Jul 25, 2024 •

edited

Loading