fix(processor): fix generic enum names #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acdibble
commented
Jan 16, 2025
| @@ -74,7 +74,7 @@ export default class Parser extends BaseParser { | |||
|
|
|||
| const result: EnumType = { | |||
| type: 'enum', | |||
| name: uncapitalize(type.lookupName), | |||
| name: uncapitalize(type.lookupName).replace('IngressEgress', this.getPalletName()), | |||
There was a problem hiding this comment.
Suggested change
| name: uncapitalize(type.lookupName).replace('IngressEgress', this.getPalletName()), | |
| name: uncapitalize(type.lookupName).replace(/^IngressEgress/, this.getPalletName()), |
is it necessary to make it a bit more strict maybe?
There was a problem hiding this comment.
no this should be ok, the name looks like PalletCfIngressEgressDepositFailedDetails and we just need to insert the chain in there somewhere to make it distinct
There was a problem hiding this comment.
the pallet name is like SolanaIngressEgress, so it just adds the chain name
jerryafr
approved these changes
Jan 16, 2025
| @@ -74,7 +74,7 @@ export default class Parser extends BaseParser { | |||
|
|
|||
| const result: EnumType = { | |||
| type: 'enum', | |||
| name: uncapitalize(type.lookupName), | |||
| name: uncapitalize(type.lookupName).replace('IngressEgress', this.getPalletName()), | |||
There was a problem hiding this comment.
Suggested change
| name: uncapitalize(type.lookupName).replace('IngressEgress', this.getPalletName()), | |
| name: uncapitalize(type.lookupName).replace(/^IngressEgress/, this.getPalletName()), |
is it necessary to make it a bit more strict maybe?
niklasnatter
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.