You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are various issues with the test suite that make it harder to maintain and use than it should be. Each of these should be addressed. However this obviously won't improve the experience for any users of ChakraCore it's a purely for developer/contributor experience hence this is low priority but still something to work on:
Many tests have unnecessary baseline files when they could just throw exceptions for failures and print 'pass' for success - baselines are strictly necessary only when tracing actions that can't be synchronously monitored/checked within javascript
There are 48 tests that don't use a baseline but print a multi-line output ('pass'/'passed' repeatedly)
Success indicators vary "Pass", "Passed", "pass", "PASSED" etc. - should be consistent.
Many tests are not well explained/don't clearly show what they're for
Many test files could be combined into larger aggregate files - which would run faster and be easier to manage
Baseline files all use CRLF line endings - ch outputs CRLF on windows but LF only on linux/macOS - currently runtests.py converts CRLF in the baselines to LF only upon every run - should update ch to do LF only and remove all CRs
#6444 makes some progress on some of these points though there is far more to be done.
The text was updated successfully, but these errors were encountered:
Another nice to have, if we drop rl.exe would be to replace the xml files that list all the tests with json, I think it could be a lot cleaner and drastically reduce the boilerplate they contain - but this is certainly not something to change anytime soon.
There are various issues with the test suite that make it harder to maintain and use than it should be. Each of these should be addressed. However this obviously won't improve the experience for any users of ChakraCore it's a purely for developer/contributor experience hence this is low priority but still something to work on:
#6444 makes some progress on some of these points though there is far more to be done.
The text was updated successfully, but these errors were encountered: