Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respond with 404 for plugins that return empty data #947

Closed
codemonkey800 opened this issue Mar 16, 2023 · 3 comments
Closed

Respond with 404 for plugins that return empty data #947

codemonkey800 opened this issue Mar 16, 2023 · 3 comments
Assignees
Labels
backend bug Something isn't working frontend good first issue P1 High Priority

Comments

@codemonkey800
Copy link
Collaborator

There's an issue on the frontend and backend right now where calling the API with a plugin is not indexed will return empty data. We should update both the frontend to display a 404 page, and the backend to respond with a 404 status code if the plugin object is empty

Backend

image

Frontend

image

@codemonkey800 codemonkey800 added the bug Something isn't working label Mar 16, 2023
@codemonkey800
Copy link
Collaborator Author

This is how our current 404 pages look like, they're very basic 😆

image

@richaagarwal
Copy link
Collaborator

I've taken care of the backend portion in #1226

@codemonkey800 Updating the current 404 page seems less critical, it's basic but I think it does the job? Let me know if you still think frontend work is needed for this.

@richaagarwal richaagarwal self-assigned this Aug 18, 2023
@richaagarwal richaagarwal moved this from In Code Review to Pending QA & Release in napari hub backlog Aug 18, 2023
@richaagarwal
Copy link
Collaborator

This is working on staging as expected (e.g. https://staging.napari-hub.org/plugins/foobar) and pending a production release.

@github-project-automation github-project-automation bot moved this from Pending QA & Release to Done in napari hub backlog Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend bug Something isn't working frontend good first issue P1 High Priority
Projects
Status: Done
Development

No branches or pull requests

3 participants