Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring pasting images form word #1225

Open
msamsel opened this issue Nov 24, 2017 · 0 comments
Open

Refactoring pasting images form word #1225

msamsel opened this issue Nov 24, 2017 · 0 comments
Labels
plugin:pastefromword The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:task Any other issue (refactoring, typo fix, etc).
Milestone
Backlog

Comments

@msamsel
Copy link
Contributor

msamsel commented Nov 24, 2017

Are you reporting a feature request or a bug?

Other
code refactoring

related to: #1214

Provide detailed reproduction steps (if any)

Pasting images from word has few possible ways for improvements:

  • Entire logic should be hidden inside default.js filter
  • Embedding images should be execute together with word filtering not in separate event
  • Embedding images should process htmlParser structure not the final string
  • CKEDITOR.cleanWord should have input with object containing text/html and text/rtf instead of string copy

Other details

  • Browser: …
  • OS: …
  • CKEditor version: 4.8.0
  • Installed CKEditor plugins: pastefromword
@msamsel msamsel added status:confirmed An issue confirmed by the development team. type:task Any other issue (refactoring, typo fix, etc). labels Nov 24, 2017
@mlewand mlewand added this to the 4.8.1 milestone Nov 24, 2017
@mlewand mlewand added target:minor Any docs related issue that can be merged into a master or major branch. plugin:pastefromword The plugin which probably causes the issue. labels Nov 24, 2017
@msamsel msamsel self-assigned this Jan 8, 2018
@msamsel msamsel mentioned this issue Jan 9, 2018
Closed
2 tasks
@mlewand mlewand modified the milestones: 4.8.1, 4.9.0 Jan 17, 2018
@mlewand mlewand modified the milestones: 4.9.0, Backlog Jan 31, 2018
@msamsel msamsel removed their assignment Sep 16, 2019
@f1ames f1ames removed the target:minor Any docs related issue that can be merged into a master or major branch. label Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
plugin:pastefromword The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:task Any other issue (refactoring, typo fix, etc).
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@f1ames @mlewand @msamsel