Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory leaks caused by CKEDITOR.filter.instances storing nested editables' filters forever #1722

Closed
jswiderski opened this issue Feb 28, 2018 · 0 comments · Fixed by #1770
Closed

Fix memory leaks caused by CKEDITOR.filter.instances storing nested editables' filters forever #1722

jswiderski opened this issue Feb 28, 2018 · 0 comments · Fixed by #1770
Labels
status:confirmed An issue confirmed by the development team. support An issue reported by a commercially licensed client. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Milestone
4.11.0

Comments

@jswiderski
Copy link
Contributor

Are you reporting a feature request or a bug?

Bug

References

Provide detailed reproduction steps (if any)

Every nested editable which has allowed content rules defined has its filter instance. These instances are stored in nested editable instances, which most likely are correctly garbage collected. But filter instances are also stored in CKEDITOR.filter.instances and they are kept there forever.

We could have filter.destroy() method removing instance from the instances hash and doing other cleanup if necessary. Then we could destroy filters when destroying widgets.

Expected result

All filter instances should be removed.

Actual result

Filter instances are also stored in CKEDITOR.filter.instances and they are kept there forever.

Other details

  • Browser: …
  • OS: …
  • CKEditor version: 4.3.0+
  • Installed CKEditor plugins: …
@mlewand mlewand added the status:confirmed An issue confirmed by the development team. label Feb 28, 2018
@mlewand mlewand added this to the Backlog milestone Feb 28, 2018
@mlewand mlewand added the target:minor Any docs related issue that can be merged into a master or major branch. label Feb 28, 2018
@jswiderski jswiderski added support An issue reported by a commercially licensed client. type:bug A bug. labels Feb 28, 2018
@jacekbogdanski jacekbogdanski mentioned this issue Mar 9, 2018
Merged
2 tasks
@mlewand mlewand modified the milestones: Backlog, 4.11.0 Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status:confirmed An issue confirmed by the development team. support An issue reported by a commercially licensed client. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Projects
None yet
Milestone
4.11.0
Development

Successfully merging a pull request may close this issue.

Removed memory leak caused by CKEDITOR.filter.instances ckeditor/ckeditor4
2 participants
@jswiderski @mlewand