-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use "https" as default protocol for links #2227
Comments
I understand reason of this feature request (as Chrome starts to mark non-HTTPS sites as non-secure), but I'm quite skeptical. @seeallie, do you have any statistics showing that HTTPS adoption is high enough to justify such switch? |
@Comandeer @seeallie Firstly I can see it as an opt-in feature rather than rolling out |
Jut a side note: technically this should be already possible with a few lines of code using the dialogDefinition event: https://ckeditor.com/latest/samples/old/dialog/dialog.html (Setting default values for dialog window fields) |
Somewhat related issue; #2277. |
My organization recently went through a process of replacing http with https in our web system ( includes several web platforms) whenever possible. If this is a current web best practice, it would make sense for this library to set it as the default protocol while allowing other options. In addition, as @wwalc pointed out, technically it involves "a few lines of code". I very much like the configuration proposal by @mlewand |
@mlewand I tested out the "https" behavior in the codepen for preview: it worked as expected & thanks! |
@seeallie note that it's still a subject of discussion, we faced some challenges during the implementations that we need to solve before merging this feature. So make sure to keep an eye on that. |
Hi, |
@mohitnegi724 it's not possible at the moment, as documentation says:
You may report a separate feature request issue for this one. |
I set link default values this way:
|
Type of report
Feature request
Provide description of the new feature
Change the default protocol for links to "https" from "http". https://github.com/ckeditor/ckeditor-dev/blob/master/plugins/link/dialogs/link.js line 268
The text was updated successfully, but these errors were encountered: