Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widget gets focus when typing with form input elements #3587

Closed
jacekbogdanski opened this issue Oct 18, 2019 · 0 comments · Fixed by #3663
Closed

Widget gets focus when typing with form input elements #3587

jacekbogdanski opened this issue Oct 18, 2019 · 0 comments · Fixed by #3663
Assignees
Labels
browser:edge The issue can only be reproduced in the Edge (edgeHTML engine based) browser. browser:ie The issue can only be reproduced in the Internet Explorer browser. status:confirmed An issue confirmed by the development team. type:bug A bug.

Comments

@jacekbogdanski
Copy link
Member

jacekbogdanski commented Oct 18, 2019

Type of report

Bug

Provide detailed reproduction steps (if any)

The issue is caused by the https://github.com/ckeditor/ckeditor4/blob/ad381679b4436f489a65f6f397680da338024b0f/core/selection.js#L942-L954f code which is supposed to prevent editing non-editable elements on Edge and IE. However, it also makes impossible editing correct form elements like textarea, input, etc.

You may have some issue reproducing test steps on IE as it doesn't fire keydown event when typing inside form elements, however, this code path is wrong for both Edge and IEs.

  1. Open https://codepen.io/jacekbogdanski/pen/vYYXamd
  2. Add test widget (no-icon button)
  3. Focus the widget and start typing.

Expected result

Typed text is registered by widgets textarea.

Actual result

Widget gets focus on every keystroke which makes typing impossible.

Other details

  • Browser: Edge, IE
  • OS: Windows
  • CKEditor version: at least 4.11.0
@jacekbogdanski jacekbogdanski added type:bug A bug. status:confirmed An issue confirmed by the development team. browser:edge The issue can only be reproduced in the Edge (edgeHTML engine based) browser. browser:ie The issue can only be reproduced in the Internet Explorer browser. labels Oct 18, 2019
@f1ames f1ames added this to the 4.13.1 milestone Oct 18, 2019
@msamsel msamsel self-assigned this Nov 6, 2019
@f1ames f1ames modified the milestones: 4.13.1, Next, Iteration 2019-1 Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser:edge The issue can only be reproduced in the Edge (edgeHTML engine based) browser. browser:ie The issue can only be reproduced in the Internet Explorer browser. status:confirmed An issue confirmed by the development team. type:bug A bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants