Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading direction of the templates dialog leads to mistakes when choosing a template #4901

Closed
Fynn96 opened this issue Sep 21, 2021 · 1 comment · Fixed by #4911
Closed
Labels
accessibility Issue related to accessibility. plugin:templates The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:task Any other issue (refactoring, typo fix, etc).
Milestone

Comments

@Fynn96
Copy link
Contributor

Fynn96 commented Sep 21, 2021

Type of report

Bug

Provide detailed reproduction steps (if any)

In the templates plugin the selection of the template is made inside of a dialog. The dialog will close as soon as the user clicks at one of the templates. But there is a checkbox at the bottom to decide if the user wants to replace the content of the editor. As the reading direction is from top to bottom the user will first select a template and then read and (de)select the checkbox.
Unfortunately the dialog will close after selecting the template before the user will read the checkbox. This may lead to mistakes when inserting the template like the replacement of the editor content without the user wanting it.

The checkbox should either be before the template list to be in the reading direction or there should be an ok button so the dialog closes only after pressing this button.

https://codepen.io/Fynn96/pen/abwGxMx?editors=1010

  1. Open a template dialog
  2. Choose a template

Expected result

You get time to check the checkbox and decide what to to with the template.

Actual result

The dialog closes immedeately and inserts the template by replacing the whole editor content because the checkbox was seleted by default.

Other details

  • Installed CKEditor plugins: templates
@Fynn96 Fynn96 added the type:bug A bug. label Sep 21, 2021
@KarolDawidziuk KarolDawidziuk added plugin:templates The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:feature A feature request. and removed type:bug A bug. labels Sep 22, 2021
@CKEditorBot
Copy link
Collaborator

Closed in #4911

@CKEditorBot CKEditorBot added this to the 4.17.0 milestone Sep 29, 2021
@Comandeer Comandeer added accessibility Issue related to accessibility. type:bug A bug. type:task Any other issue (refactoring, typo fix, etc). and removed type:feature A feature request. type:bug A bug. labels Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Issue related to accessibility. plugin:templates The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:task Any other issue (refactoring, typo fix, etc).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants