Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple spaces in find&replace as 'replaced with' turns to a single space #5061

Closed
sculpt0r opened this issue Feb 1, 2022 · 1 comment · Fixed by #5065
Closed

Multiple spaces in find&replace as 'replaced with' turns to a single space #5061

sculpt0r opened this issue Feb 1, 2022 · 1 comment · Fixed by #5065
Assignees
@Comandeer
Labels
plugin:find The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:bug A bug.
Milestone
4.17.2

Comments

@sculpt0r
Copy link
Contributor

sculpt0r commented Feb 1, 2022 •
edited
Loading

Type of report

Bug

Provide detailed reproduction steps (if any)

  1. Open CKEditor4 sample: https://codepen.io/karoldawidziuk/pen/LYzJvdx
  2. Click Find&Replace
  3. Provide text to be replaced, e.g. h
  4. Provide text for replacement: use more than one space(e.g. 4 spaces)
  5. Use Replace or Replace All button

Expected result

What is the expected result of the above steps?
The letter h should be replaced with four spaces. Spaces probably will be encoded as   mixed with casual spaces.

Actual result

What is the actual result of the above steps?
Only a single space is used as a replacement.

Other details

I can track the same behavior back to the 4.14.0 so i looks like no regression here

  • Browser: all (Safari, FF, Chrome)
  • OS: …
  • CKEditor version: 4.17.1
  • Installed CKEditor plugins: full-all
@sculpt0r sculpt0r added type:bug A bug. status:confirmed An issue confirmed by the development team. plugin:find The plugin which probably causes the issue. size:? labels Feb 1, 2022
@sculpt0r sculpt0r changed the title Multiple spaces in find & replace as replaced text turns to single space Multiple spaces in find&replace as 'replaced with' turns to a single space Feb 1, 2022
@jacekbogdanski jacekbogdanski added the release:potential-blocker This issue potentially blocks the upcoming release (should be checked). label Feb 1, 2022
@Comandeer Comandeer mentioned this issue Feb 1, 2022
Merged
3 tasks
@CKEditorBot
Copy link
Collaborator

Closed in #5065

@CKEditorBot CKEditorBot added this to the 4.17.2 milestone Feb 4, 2022
@jacekbogdanski jacekbogdanski removed the release:potential-blocker This issue potentially blocks the upcoming release (should be checked). label Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Comandeer Comandeer

Labels
plugin:find The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:bug A bug.
Projects
None yet
Milestone
4.17.2
Development

Successfully merging a pull request may close this issue.

Fix for incorrect replacing with phrases with several spaces inside ckeditor/ckeditor4
4 participants
@Comandeer @sculpt0r @jacekbogdanski @CKEditorBot