Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow managed dependencies to manage all settings #76

Closed
loomis opened this issue Oct 31, 2016 · 4 comments
Closed

allow managed dependencies to manage all settings #76

loomis opened this issue Oct 31, 2016 · 4 comments
Labels

Comments

@loomis
Copy link

loomis commented Oct 31, 2016

The recent addition of managed dependencies to 0.3.1 was a great enhancement. We'd like to move to using the baked in managed dependencies, but we also need to have all of the non-coordinate settings managed, not just the versions.

Would this be of general enough interest to be considered for a PR? I have an initial implementation of it in https://github.com/SixSq/pomegranate/tree/manage-all-dep-options if people want to take a look.

@loomis
Copy link
Author

loomis commented Jan 13, 2017

@senior @cprice404 I've created a PR request that extends the managed dependency feature to allow all dependency options to be managed, rather than just the version. I've tested that this works with boot, but we're probably the only ones using that feature at the moment. As you two created/tested the original managed dependency feature and use (I think) leiningen with managed dependencies, I was wondering if you'd be willing to review and ideally test this patch? I think that this would give Chas the confidence to merge the PR, presuming that everything looks OK.

@cprice404
Copy link
Contributor

@loomis sure, I will try to take a look at it as soon as I can find some time!

@loomis
Copy link
Author

loomis commented Jan 17, 2017

@cprice404 Thanks. Much appreciated.

@lread
Copy link
Collaborator

lread commented Jan 17, 2023

There has been no movement on this issue for several years, I'll go ahead and close it as stale.
Please feel free to re-open if you have an interest.

@lread lread closed this as not planned Won't fix, can't repro, duplicate, stale Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants