Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vitest-pool-workers): reset module graphs to ensure module mock works in watch mode #8182

Merged
merged 3 commits into from
Feb 25, 2025

Conversation

edmundhung
Copy link
Member

@edmundhung edmundhung commented Feb 18, 2025

Fixes #6844.


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • Wrangler E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: no impact to wrangler
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: bugfix

Copy link

changeset-bot bot commented Feb 18, 2025

🦋 Changeset detected

Latest commit: 43b1bca

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 18, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13519056435/npm-package-wrangler-8182

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8182/npm-package-wrangler-8182

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13519056435/npm-package-wrangler-8182 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13519056435/npm-package-cloudflare-workers-bindings-extension-8182 -O ./cloudflare-workers-bindings-extension.0.0.0-vb7f87dda7.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vb7f87dda7.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13519056435/npm-package-create-cloudflare-8182 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13519056435/npm-package-cloudflare-kv-asset-handler-8182

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13519056435/npm-package-miniflare-8182

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13519056435/npm-package-cloudflare-pages-shared-8182

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13519056435/npm-package-cloudflare-unenv-preset-8182

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13519056435/npm-package-cloudflare-vite-plugin-8182

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13519056435/npm-package-cloudflare-vitest-pool-workers-8182

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13519056435/npm-package-cloudflare-workers-editor-shared-8182

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13519056435/npm-package-cloudflare-workers-shared-8182

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13519056435/npm-package-cloudflare-workflows-shared-8182

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20250214.0
workerd 1.20250214.0 1.20250214.0
workerd --version 1.20250214.0 2025-02-14

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@edmundhung edmundhung force-pushed the edmundhung/vitest-mock-module-in-watch-mode branch from 1baf04c to 3af901e Compare February 21, 2025 13:43
@edmundhung edmundhung force-pushed the edmundhung/vitest-mock-module-in-watch-mode branch from 3af901e to 452a813 Compare February 21, 2025 13:47
@edmundhung edmundhung marked this pull request as ready for review February 21, 2025 15:13
@edmundhung edmundhung requested a review from a team as a code owner February 21, 2025 15:13
@edmundhung edmundhung merged commit 085a37a into main Feb 25, 2025
16 checks passed
@edmundhung edmundhung deleted the edmundhung/vitest-mock-module-in-watch-mode branch February 25, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

🐛 BUG: Vitest mocks fail when test reruns in watch mode
2 participants