-
Notifications
You must be signed in to change notification settings - Fork 788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove unnecessary flags passed to create-next-app
when creating Next.js apps in experimental mode
#8240
fix: remove unnecessary flags passed to create-next-app
when creating Next.js apps in experimental mode
#8240
Conversation
…ng Next.js apps in experimental mode
🦋 Changeset detectedLatest commit: bbc811a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@@ -0,0 +1,9 @@ | |||
--- | |||
"create-cloudflare": patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this could almost be considered a minor
since it adds the possibility to customize the app more... I'm happy with either patch
or minor
🙂
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13498799416/npm-package-wrangler-8240 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8240/npm-package-wrangler-8240 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13498799416/npm-package-wrangler-8240 dev path/to/script.js Additional artifacts:cloudflare-workers-bindings-extension: wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13498799416/npm-package-cloudflare-workers-bindings-extension-8240 -O ./cloudflare-workers-bindings-extension.0.0.0-v868cdf870.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v868cdf870.vsix create-cloudflare: npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13498799416/npm-package-create-cloudflare-8240 --no-auto-update @cloudflare/kv-asset-handler: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13498799416/npm-package-cloudflare-kv-asset-handler-8240 miniflare: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13498799416/npm-package-miniflare-8240 @cloudflare/pages-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13498799416/npm-package-cloudflare-pages-shared-8240 @cloudflare/unenv-preset: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13498799416/npm-package-cloudflare-unenv-preset-8240 @cloudflare/vite-plugin: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13498799416/npm-package-cloudflare-vite-plugin-8240 @cloudflare/vitest-pool-workers: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13498799416/npm-package-cloudflare-vitest-pool-workers-8240 @cloudflare/workers-editor-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13498799416/npm-package-cloudflare-workers-editor-shared-8240 @cloudflare/workers-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13498799416/npm-package-cloudflare-workers-shared-8240 @cloudflare/workflows-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13498799416/npm-package-cloudflare-workflows-shared-8240 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming this passes CI checks and has been tested manually.
Yes, I've tested this manually 🙂 naturally I haven't tested all possible combinations as that would take hours but I'm quite sure all the options that were being set were not necessary as we support them both on and off (@vicb can corroborate that 🙂) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and I think it's good to match the non experimental template
This change removes a set of flags that get passed to
create-next-app
that force the generated Next.jsapplication to have specific settings (e.g. typescript, tailwind, src directory, etc...) which are not
actually mandatory/recommended for the use of the open-next Cloudflare adapter