Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vitest-pool-workers): responses from fetchMock should have immutable headers #8254

Merged
merged 3 commits into from
Feb 26, 2025

Conversation

edmundhung
Copy link
Member

Fixes #7468.


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • Wrangler E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: no impact outside of vitest-pool-workers
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: bugfix

Copy link

changeset-bot bot commented Feb 25, 2025

🦋 Changeset detected

Latest commit: e54d234

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 25, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13550691793/npm-package-wrangler-8254

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8254/npm-package-wrangler-8254

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13550691793/npm-package-wrangler-8254 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13550691793/npm-package-cloudflare-workers-bindings-extension-8254 -O ./cloudflare-workers-bindings-extension.0.0.0-v482e3cfe2.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v482e3cfe2.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13550691793/npm-package-create-cloudflare-8254 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13550691793/npm-package-cloudflare-kv-asset-handler-8254

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13550691793/npm-package-miniflare-8254

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13550691793/npm-package-cloudflare-pages-shared-8254

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13550691793/npm-package-cloudflare-unenv-preset-8254

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13550691793/npm-package-cloudflare-vite-plugin-8254

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13550691793/npm-package-cloudflare-vitest-pool-workers-8254

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13550691793/npm-package-cloudflare-workers-editor-shared-8254

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13550691793/npm-package-cloudflare-workers-shared-8254

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13550691793/npm-package-cloudflare-workflows-shared-8254

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20250214.1
workerd 1.20250214.0 1.20250214.0
workerd --version 1.20250214.0 2025-02-14

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@edmundhung edmundhung marked this pull request as ready for review February 25, 2025 12:43
@edmundhung edmundhung requested a review from a team as a code owner February 25, 2025 12:43
@edmundhung edmundhung merged commit 2b92a65 into main Feb 26, 2025
16 checks passed
@edmundhung edmundhung deleted the edmundhung/fetch-mock-immutable-headers branch February 26, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

🐛 BUG: Responses from fetchMock do not have immutable headers
2 participants