-
Notifications
You must be signed in to change notification settings - Fork 788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make builder.buildApp
overridable
#8266
Conversation
🦋 Changeset detectedLatest commit: 92cb809 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
It would be great to have a test that proves this works. I note that you have ticked the box saying "tests included" but that is not accurate, right? |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13544131379/npm-package-wrangler-8266 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8266/npm-package-wrangler-8266 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13544131379/npm-package-wrangler-8266 dev path/to/script.js Additional artifacts:cloudflare-workers-bindings-extension: wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13544131379/npm-package-cloudflare-workers-bindings-extension-8266 -O ./cloudflare-workers-bindings-extension.0.0.0-v4f1e0bdbe.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v4f1e0bdbe.vsix create-cloudflare: npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13544131379/npm-package-create-cloudflare-8266 --no-auto-update @cloudflare/kv-asset-handler: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13544131379/npm-package-cloudflare-kv-asset-handler-8266 miniflare: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13544131379/npm-package-miniflare-8266 @cloudflare/pages-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13544131379/npm-package-cloudflare-pages-shared-8266 @cloudflare/unenv-preset: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13544131379/npm-package-cloudflare-unenv-preset-8266 @cloudflare/vite-plugin: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13544131379/npm-package-cloudflare-vite-plugin-8266 @cloudflare/vitest-pool-workers: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13544131379/npm-package-cloudflare-vitest-pool-workers-8266 @cloudflare/workers-editor-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13544131379/npm-package-cloudflare-workers-editor-shared-8266 @cloudflare/workers-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13544131379/npm-package-cloudflare-workers-shared-8266 @cloudflare/workflows-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13544131379/npm-package-cloudflare-workflows-shared-8266 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
2bd1ad0
to
d0948f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it!
Fixes #000.
Make it possible to override
builder.buildApp
in the user config or prior plugins. As well as allowing users to provide their ownbuildApp
function, this also makes framework integrations less dependent on plugin order.I haven't added a specific playground to test this as it is likely the
buildApp
API might change soon.