Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestSentenceClassifier seems to test texts without sentences #1094

Open
kwalcock opened this issue Nov 15, 2021 · 0 comments
Open

TestSentenceClassifier seems to test texts without sentences #1094

kwalcock opened this issue Nov 15, 2021 · 0 comments
Assignees

Comments

@kwalcock
Copy link
Member

At

else{
// If the sentence could not be annotated, automatically mark it as invalid
// It turns out that there are four sentences that eidos failed to annotate.
preds.append(0)
invalidSentCount+=1
}
val label = sentenceClassifierEvaluationData(i)._2
, the test assigns 0 to the prediction and takes whatever label there is to make a calculation even when there is no sentence. I don't think this should happen, Both numbers should be thrown out as if it never happened. In the four cases, there are run-on sentences from tables or captions that we are skipping.

@kwalcock kwalcock self-assigned this Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant