refactors audio player (by adding a 516 version with nicer code) #8606
+101
−113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Absolucy
added a commit
to Absolucy/Monkestation
that referenced
this pull request
Feb 27, 2025
|
From my testing this doesn't stop music if a song is already playing anymore meaning multiple songs can play at once This can easily be fixed by calling |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and when i no longer need to support 515 i can simply delete the old onethe old one was targeting ie8 compatibility and the new one works on ie11 so🆑
admin: the audio player works on 516 again - go crazy
/:cl: