Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[package] mimalloc/*: Unexpected override of MI_WIN_REDIRECT #26646

Open
NickGaertner opened this issue Feb 19, 2025 · 0 comments
Open

[package] mimalloc/*: Unexpected override of MI_WIN_REDIRECT #26646

NickGaertner opened this issue Feb 19, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@NickGaertner
Copy link

Description

The conan recipe silently turns off the redirect mechanism on Windows by setting MI_WIN_REDIRECT = "OFF". Unfortunately, the mechanism is required on Windows for mimalloc to properly work with third party code, see their description for details.

The override is unexpected, since it

  • contradicts the upstream CMake default value,
  • isn't communicated to the package consumer and
  • results in mysteriously broken builds, which seem to work until third party libraries are involved.

The PR (#23709) that introduced that line only did it so to fix intermediate versions 1.8.4 and 2.1.4. The final versions added were 1.8.7 and 2.8.7 instead, which would've built fine without setting MI_WIN_REDIRECT = "OFF" (verified locally).

I propose to add a recipe option for MI_WIN_REDIRECT to add transparency for users but disable it by default to avoid breaking builds.

Package and Environment Details

  • Package Name/Version: mimalloc/*
  • Operating System+version: Windows*

Conan profile

# The profile I used for tests
[settings]
arch=x86_64
build_type=Release
compiler=msvc
compiler.cppstd=14
compiler.runtime=dynamic
compiler.runtime_type=Release
compiler.version=194

Steps to reproduce

N/A

Logs

N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant