[chore] install for command #181
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #181 +/- ##
==========================================
- Coverage 98.23% 98.15% -0.08%
==========================================
Files 9 9
Lines 1077 1086 +9
==========================================
+ Hits 1058 1066 +8
- Misses 19 20 +1 ☔ View full report in Codecov by Sentry. |
mattkram
approved these changes
Feb 8, 2025
| @pytest.mark.parametrize( | ||
| "install_args,expected_env", [("", "bbb"), ("--for-command=default", "default")] | ||
| ) | ||
| def test_install_env_for_command(project_directory_factory, install_args, expected_env): |
There was a problem hiding this comment.
Looks good, but maybe we should isolate the "determine environment from args" logic into a function and just unit test to speed things up?
There was a problem hiding this comment.
Yeah, I'll do that.
|
The pydantic errors are limited to conda version 24.1 and 24.4. I'm looking into reproducing this locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
install an env for a specified command (especially if it is not default)