Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix conversion to datetime64[ns] for naive datetimes #145

Merged
merged 1 commit into from
May 23, 2023
Merged

Conversation

snowman2
Copy link
Member

@snowman2 snowman2 commented May 23, 2023

Related #143

@snowman2 snowman2 added the bug Something isn't working label May 23, 2023
@snowman2 snowman2 requested a review from justingruca May 23, 2023 20:46
@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03 🎉

Comparison is base (92033cb) 97.21% compared to head (37355b0) 97.24%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #145      +/-   ##
==========================================
+ Coverage   97.21%   97.24%   +0.03%     
==========================================
  Files          14       14              
  Lines         431      436       +5     
==========================================
+ Hits          419      424       +5     
  Misses         12       12              
Impacted Files Coverage Δ
geocube/vector_to_cube.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@snowman2
Copy link
Member Author

Thanks @justingruca 👍

@snowman2 snowman2 merged commit c4bb4fa into master May 23, 2023
@snowman2 snowman2 deleted the time_bug branch May 23, 2023 21:17
@snowman2 snowman2 added this to the 0.4.2 milestone Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants