BUG: Ignore categorical columns not in measurements #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snowman2
commented
Jan 23, 2024
| @@ -63,17 +69,31 @@ def load_vector_data( | |||
| logger = get_logger() | |||
|
|
|||
| if isinstance(vector_data, (str, os.PathLike)): | |||
| vector_data = geopandas.read_file(vector_data) | |||
| try: | |||
| vector_data = geopandas.read_file(vector_data, include_fields=measurements) | |||
There was a problem hiding this comment.
Read subset of measurements for efficiency.
snowman2
commented
Jan 23, 2024
| if "geometry" not in vector_data.columns: | ||
|
|
||
| if measurements is not None: | ||
| vector_data = vector_data[measurements + [vector_data.geometry.name]] |
There was a problem hiding this comment.
Ensure only measurements requested in dataframe.
snowman2
force-pushed
the
categorical
branch
3 times, most recently
from
5e21d3e to
1495ab7
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #161 +/- ##
==========================================
- Coverage 97.03% 96.23% -0.80%
==========================================
Files 14 14
Lines 439 452 +13
==========================================
+ Hits 426 435 +9
- Misses 13 17 +4 ☔ View full report in Codecov by Sentry. |
justingruca
approved these changes
Jan 23, 2024
|
Thanks @justingruca 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make_geocubefor a second categorical variable fails withKeyError#160docs/history.rstfor all changes anddocs/geocube.rstfor new API