Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop node.js 12 support and bump target to es2020 #1002

Closed
webmaster128 opened this issue Jan 22, 2022 · 2 comments · Fixed by #1343
Closed

Drop node.js 12 support and bump target to es2020 #1002

webmaster128 opened this issue Jan 22, 2022 · 2 comments · Fixed by #1343
Milestone
0.30.0

Comments

@webmaster128
Copy link
Member

This is what https://github.com/paulmillr/noble-hashes uses too and we want to use noble hashes.

I guess applications can transpile this down to their supported target lists anyways.
@webmaster128 webmaster128 added this to the 0.28.0 milestone Jan 22, 2022
@webmaster128 webmaster128 mentioned this issue Jan 27, 2022
Merged
@webmaster128
Copy link
Member Author

Node.js < 14 does not support the Nullish coalescing operator from es2020, i.e. we need to drop node 12 support first.

Logical nullish assignment (??=) requires node.js 15 (ES 12/2021).

@webmaster128 webmaster128 changed the title Bump JS output target form es2017 to es2020 Drop node.js 12 support and bump target to es2020 Jan 27, 2022
@webmaster128 webmaster128 removed this from the 0.28.0 milestone Jan 27, 2022
@webmaster128 webmaster128 added this to the 0.30.0 milestone Mar 18, 2022
@webmaster128
Copy link
Member Author

Node.js 12 EOLed on 2022-04-30. We can stop supporting it with CosmJS 0.29.0 and move to es2020 in the next release.

@webmaster128 webmaster128 mentioned this issue Aug 15, 2022
Merged
@webmaster128 webmaster128 mentioned this issue Dec 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.30.0
Development

Successfully merging a pull request may close this issue.

Target es2020 cosmos/cosmjs
1 participant
@webmaster128