Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Block.evidence non-optional in Tendermint client #1011

Closed
webmaster128 opened this issue Jan 26, 2022 · 0 comments · Fixed by #1023
Closed

Make Block.evidence non-optional in Tendermint client #1011

webmaster128 opened this issue Jan 26, 2022 · 0 comments · Fixed by #1023
Assignees
Milestone

Comments

@webmaster128
Copy link
Member

In

export interface Block {
  readonly header: Header;
  /**
   * For the block at height 1, last commit is not set.
   */
  readonly lastCommit: Commit | null;
  readonly txs: readonly Uint8Array[];
  readonly evidence?: readonly Evidence[];
}

the evidence field is always set, even if an empty array. There is no need to differentiate between an empty array and undefined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants