Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: New broadcast logic hides errors #800

Closed
clockworkgr opened this issue May 12, 2021 · 4 comments · Fixed by #805
Closed

bug: New broadcast logic hides errors #800

clockworkgr opened this issue May 12, 2021 · 4 comments · Fixed by #805
Milestone
0.25.3

Comments

@clockworkgr
Copy link
Contributor

The latest implementation of broadcastTx that polls the chain for the tx result hides all pre-commit errors.

https://github.com/cosmos/cosmjs/blob/main/packages/stargate/src/stargateclient.ts#L329

This will return a timeout error for any kind of invalid transaction including insufficient fees. etc.
@webmaster128
Copy link
Member

This would explain the bahaviour described in confio/ts-relayer#180

@clockworkgr
Copy link
Contributor Author

ah..never noticed that issue....same thing happened to us and I just worked back through the code and found it :)

fwiw, ibc-setup costs about 2.2m gas on each chain

@webmaster128 webmaster128 mentioned this issue May 13, 2021
Closed
@webmaster128 webmaster128 added this to the 0.25.3 milestone May 14, 2021
@webmaster128 webmaster128 mentioned this issue May 17, 2021
Merged
@webmaster128
Copy link
Member

Fix is in #805. Happy for any 👀 on it.

@webmaster128
Copy link
Member

Released as 0.25.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.25.3
Development

Successfully merging a pull request may close this issue.

Fix error propagation for checkTx errors cosmos/cosmjs
2 participants
@webmaster128 @clockworkgr