Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: make val privkey modular #21587

Closed
tac0turtle opened this issue Sep 8, 2024 · 0 comments · Fixed by #21608
Closed

[Feature]: make val privkey modular #21587

tac0turtle opened this issue Sep 8, 2024 · 0 comments · Fixed by #21608
Assignees
@tac0turtle
Labels
C: comet T:feature-request

Comments

@tac0turtle
Copy link
Member

Summary

Comet rc2 contains api breaks from rc1. In this pr #21586 i hardcode privkeys to ed22519 but we should make this modular allowing the application developer to pass in the key they desire.

Problem Definition

No response

Proposed Feature

Allow the application developer from baseapp and/or serverv2 to pass in a validator key that will be used in order to start the node
@tac0turtle tac0turtle self-assigned this Sep 8, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Cosmos-SDK Legacy Sep 8, 2024
@tac0turtle tac0turtle changed the title [Feature]: make val privkey modualr [Feature]: make val privkey modular Sep 8, 2024
@tac0turtle tac0turtle mentioned this issue Sep 9, 2024
Merged
12 tasks
@github-project-automation github-project-automation bot moved this from 🤸‍♂️ In Progress to 🥳 Done in Cosmos-SDK Legacy Sep 18, 2024
@mergify mergify bot mentioned this issue Sep 18, 2024
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tac0turtle tac0turtle

Labels
C: comet T:feature-request
Projects
Cosmos-SDK Legacy
Status: 🥳 Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: make validator key injectable by application developers cosmos/cosmos-sdk
2 participants
@tac0turtle and others