Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid validator pubKey halts state machine #2945

Closed
3 of 4 tasks
hendrikhofstadt opened this issue Nov 29, 2018 · 1 comment
Closed
3 of 4 tasks

Invalid validator pubKey halts state machine #2945

hendrikhofstadt opened this issue Nov 29, 2018 · 1 comment
Assignees
Labels

Comments

@hendrikhofstadt
Copy link
Contributor

hendrikhofstadt commented Nov 29, 2018

Summary of Bug

In Tendermint v0.27.0 only pubKeyTypes specified in ConsensusParams are allowed.

We can however still create validators with invalid key types which halts the chain since applyblock fails.

This is causing all of the integration tests to fail at the moment. Fixed in #2943 (tests only)

The handler for MsgCreateValidator needs to check whether the key is of a valid type.

Steps to Reproduce

  • Create validator with invalid key type e.g. secp256k1

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@alexanderbez
Copy link
Contributor

wow! Great catch @SLAMPER!

@hendrikhofstadt hendrikhofstadt changed the title Invalid validator key crashes network Invalid validator pubKey halts state machine Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants