Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ValidaterBasic Check in BaseApp #5713

Closed
4 tasks
alexanderbez opened this issue Feb 27, 2020 · 0 comments · Fixed by #5718
Closed
4 tasks

Fix ValidaterBasic Check in BaseApp #5713

alexanderbez opened this issue Feb 27, 2020 · 0 comments · Fixed by #5718
Assignees
@alexanderbez
Labels
C:baseapp T:Bug

Comments

@alexanderbez
Copy link
Contributor

Summary of Bug

https://github.com/cosmos/cosmos-sdk/blob/master/baseapp/baseapp.go#L583-L586

A regression exists in BaseApp due to the errors handling refactor where if a message's ValidateBasic fails, it will panic during CheckTx as the gas meter is nil.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexanderbez alexanderbez

Labels
C:baseapp T:Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Return Empty GasInfo on Failed Msg Validation cosmos/cosmos-sdk
1 participant
@alexanderbez