Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create migration for keyring keys. #8323

Closed
2 of 4 tasks
robert-zaremba opened this issue Jan 13, 2021 · 2 comments
Closed
2 of 4 tasks

Create migration for keyring keys. #8323

robert-zaremba opened this issue Jan 13, 2021 · 2 comments
Labels
C:Encoding C:Keys Keybase, KMS and HSMs
Milestone
Feature Backlog

Comments

@robert-zaremba
Copy link
Collaborator

Summary

Keyring is using a legacy codec and is fragile for structure linear changes.

Problem Definition

Legacy Amino codecs are deprecated. Moreover we have a problem with extending or reducing structure of keyring objects:

  • legacy.Cdc.UnmarshalBinaryLengthPrefixed fails if we reduce structure (remove some fields from the structure we used to encode an object)

Proposal

Create a migration for keyring keys:

  • don't use legacy codec
  • remove crypto/keyring.multiInfo.PubKeys field

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@robert-zaremba robert-zaremba added C:Keys Keybase, KMS and HSMs C:Encoding labels Jan 13, 2021
@robert-zaremba robert-zaremba added this to the v0.42 milestone Jan 13, 2021
@robert-zaremba robert-zaremba mentioned this issue Jan 13, 2021
Merged
12 tasks
@amaury1093
Copy link
Contributor

related: #7108

@robert-zaremba
Copy link
Collaborator Author

Let's close it in favor of #7108

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C:Encoding C:Keys Keybase, KMS and HSMs
Projects
None yet
Milestone
Feature Backlog
Development

No branches or pull requests
2 participants
@robert-zaremba @amaury1093