Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

absorb capability module #3076

Closed
3 tasks
tac0turtle opened this issue Jan 27, 2023 · 1 comment · Fixed by #3097
Closed
3 tasks

absorb capability module #3076

tac0turtle opened this issue Jan 27, 2023 · 1 comment · Fixed by #3097
Assignees
@damiannolan @chatton
Labels
type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.
Milestone
v8.0.0

Comments

@tac0turtle
Copy link
Member

Summary

The capability module was created with IBC in mind, but when ibc was spun out to its own repo, it was left in the sdk. I would like to move the capability module from the sdk to ibc-go since it's not used in the sdk and no other modules use it.

Proposal

Move capability module to ibc-go, where it is used

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@tac0turtle
Copy link
Member Author

it would be good to do this before cosmos/cosmos-sdk#14804 is released as this would mean two api breaks for users instead of one

@crodriguezvega crodriguezvega added needs discussion Issues that need discussion before they can be worked on type: refactor Architecture, code or CI improvements that may or may not tackle technical debt. labels Jan 29, 2023
This was referenced Jan 31, 2023
Closed
Closed
@crodriguezvega crodriguezvega moved this to Todo in ibc-go Mar 5, 2023
@crodriguezvega crodriguezvega added this to the v8.0.0 milestone Mar 5, 2023
@crodriguezvega crodriguezvega removed the needs discussion Issues that need discussion before they can be worked on label Mar 20, 2023
@crodriguezvega crodriguezvega moved this from Todo to In progress in ibc-go Mar 20, 2023
@crodriguezvega crodriguezvega mentioned this issue Mar 20, 2023
Merged
9 tasks
@damiannolan damiannolan moved this from In progress to In review in ibc-go Mar 21, 2023
@github-project-automation github-project-automation bot moved this from In review to Todo in ibc-go Mar 30, 2023
@damiannolan damiannolan moved this from Todo to Done in ibc-go Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@damiannolan damiannolan

@chatton chatton

Labels
type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.
Projects
ibc-go
Archived in project
Milestone
v8.0.0
Development

Successfully merging a pull request may close this issue.

proposal: capability addition to ibc-go structure cosmos/ibc-go
4 participants
@damiannolan @crodriguezvega @chatton @tac0turtle