Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0.0-alpha.2]: Preview missing in Craft Solo #14050

Closed
wsydney76 opened this issue Dec 18, 2023 · 5 comments
Closed

[5.0.0-alpha.2]: Preview missing in Craft Solo #14050

wsydney76 opened this issue Dec 18, 2023 · 5 comments
Labels

Comments

@wsydney76
Copy link

wsydney76 commented Dec 18, 2023

What happened?

Description

The Preview/View buttons are missing in Craft Solo.

Craft 4:

image

Same entry in Craft 5:

image

Steps to reproduce

  1. Edit an entry

Expected behavior

Be able to preview the edited entry.

Actual behavior

Nope.

/Klara

Craft CMS version

Craft Solo 5.0.0-alpha.2

PHP version

8.2.13

Operating system and version

Linux 5.15.133.1-microsoft-standard-WSL2

Database type and version

MySQL 8.0.33

Image driver and version

Imagick 3.7.0 (ImageMagick 6.9.11-60)

Installed plugins and versions

None

@wsydney76 wsydney76 added the bug label Dec 18, 2023
@bencroker
Copy link
Contributor

The View button has been moved into the bredcrumb bar, see #13902.

The Preview button, however, is no longer appearing.

Screenshot 2023-12-20 at 10 47 12

brandonkelly added a commit that referenced this issue Dec 21, 2023
[ci skip]
@brandonkelly
Copy link
Member

Craft 5.0.0-alpha.3 is out with a fix for this. Thanks for reporting!

@wsydney76
Copy link
Author

@brandonkelly Thanks, unfortunately not working on my side.

Just done this:

  1. Fresh install of alpha.3 as described in the upgrade guide
  2. Created a section: No Preview/View buttons
  3. Switch to Craft Pro: Preview/View appear, pointing to the entry url, although no preview targets are defined.
  4. Define some nonsense preview targets in the section setup: buttons do not respect this settings, still one preview target to entry url.
  5. Switch back to Solo: Now the preview targets defined in step 4 appear:
    image

Looks like the behaviors of Solo/Pro are reversed.

Suspect?

if ($this->fieldId || Craft::$app->getEdition() === Craft::Pro) {

/Karla

PS.
Slightly confused about having

  • a 'View in new tab' action in the breadcrumb bar (to entry url without preview tokens, so leading to 'page not found' for unpublished entry, or probably showing published content)
  • the 'View' button (also opens a new tab, but with tokens)

Wording?

brandonkelly added a commit that referenced this issue Dec 22, 2023
@brandonkelly
Copy link
Member

Doh, thanks! This is now fixed for the next release.

@brandonkelly
Copy link
Member

Craft 5.0.0-alpha.4 is out with a fix for this. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants