Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x]: Internal server issue when bulk editing an unpublished canonical draft without a title #15138

Closed
MoritzLost opened this issue Jun 4, 2024 · 2 comments
Assignees
Labels

Comments

@MoritzLost
Copy link
Contributor

What happened?

Description

When I make any changes to an unpublished canonical draft that doesn't have a title yet, I get a generic A server error occured notification and my changes aren't saved.

Steps to reproduce

  1. Click on create a new entry (using any entry type with a visible title field and without a title format)
  2. Enter content in any field but the title, so an unpublished draft is created, but don't save yet
  3. Return to the entry index and start bulk editing. Edit any field except the title and try to save.

Expected behavior

My bulk edit should still work, even if some required fields are missing. Other validation errors don't prevent the bulk edit from applying, but a missing title seems to be a special case. But when bulk editing, the expectation is always that my edits are applied even if there are errors in other fields.

If it's not possible to save the entry for any reason, the error message should be more specific and actionable, to allow me to recover from the error and still save all the other entries I may have edited. Otherwise, those edits are lost and have to be redone.

Actual behavior

Edits are not applied (to any elements, including those that don't cause an error), and the error doesn't tell me what's wrong. There is no clear path to recovering from this error and still applying the pending changes.

Craft CMS version

5.1.8

PHP version

8.2

Operating system and version

No response

Database type and version

No response

Image driver and version

No response

Installed plugins and versions

@i-just
Copy link
Contributor

i-just commented Jun 4, 2024

Hi, thanks for reporting! I raised a PR for this.

@brandonkelly
Copy link
Member

Craft 5.1.9 is out now with that fix. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants