-
Notifications
You must be signed in to change notification settings - Fork 645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve sidebar and wide screen styling #14281
Improve sidebar and wide screen styling #14281
Conversation
…mprove-sidebar-and-wide-screen-styling
@brianjhanson Looks really good! Let’s have the global header stay within the same maximum width as everything before it. (The bottom border should still stretch all the way though.) |
…mprove-sidebar-and-wide-screen-styling
…mprove-sidebar-and-wide-screen-styling
Brian, you'd asked about things that "appear conditionally" on the call, this morning—the |
Thank you! You're correct, that's already handled. I'd kind of like it to be more of an obvious indicator, but that's for another PR. |
…mprove-sidebar-and-wide-screen-styling
…g' of https://github.com/craftcms/cms into feature/cms-1220-improve-sidebar-and-wide-screen-styling # Conflicts: # src/web/assets/cp/dist/css/cp.css # src/web/assets/cp/dist/css/cp.css.map
@wmdhosting The SEOmatic sidebar bug is another sypmtom of nystudio107/craft-seomatic#1412, which Andrew is working on a fix for. I’ve fixed the “Entry Types” bug – thanks for reporting that. Design is subjective but I’m not sure there’s a way we could nicely style Craft for 5060px-wide viewports. Feel free to post a new feature request as a discussion, about making the max-width configurable, though. |
OK :) Just info, have wide screen and everythign works perfect as it is now.. for main content area |
Just another subjective opinion; even at ~2500px I don't really see the point of restricting the max width. Especially for element indexes, where it's actually useful to add a lot of columns and use the available screen estate to get more information at a glance. For the edit page area, it could probably benefit from an even narrower max width, but maybe that can be solved without limiting the element indexes? Also, the visual hierarchy between the main menu, section menu, and the element index is kind of in limbo at the moment. Partly because the section menu isn't connected to the main menu anymore, and the design for the element index is the only thing that isn't flat. But this is maybe WIP? |
Agree with that. @brianjhanson let’s work on making it possible for certain pages to opt out of the max-width, and take advantage of it on all element index pages. |
We decided to just remove the maximum content width for now. (#14321) |
Well... it was nice while it lasted! IMO the entry editing screen was much more usable, focused, and just plain better looking with the constrained width. Now it's a sea of white again and especially the text fields look wrong with that line length. But yes, table views with lots of columns warrant special consideration. I think on wide screens there could exist a toggle to turn the constraint on/off. IIRC Notion had somethink like that for tables. Also maybe the header should not be aligned with the narrow container (that would definitely be the better choice if the content width was variable, to have a constant visual anchor). Anyway, I don't want to sound negative, I think the new sidebar looks very nice indeed, and the fact that it's collapsible actually helps a lot on narrower viewports (and I suspect that will be a larger demographic than people with huge screens). |
what kind/size of monitor do you have |
I actually have 3 monitors on my desk, with 3 virtual desktops, so it's like having 9 monitors. As you can imagine I do a lot of window managing, moving, snapping and resizing and I use assisting software for that. Sometimes though, I like to go full screen to focus on stuff. I also design sites and interfaces daily for a living, some of them with complex forms and UIs, backend dashboards etc. So, I appreciate the pitfalls and complexities of adapting layouts to all kinds of screen sizes. I try to approach things with an algorithmic mindset and sensible constraints, so the UI adapts to the user, not the other way around. It's not easy, I'm not perfect at it, but I enjoy the iterative nature of the process. But now I started bubbling! Where was I? 😂 Ah yes! I trust the matter of the content width will be improved sometime down the road and I wouldn't dream of imposing my own preferences on the design of a product used by thousands. |
Man you cant be focused with that setup anyway :) |
I've found my ways! :) I miss a minimal setup though. Anyone want to gift me a Vision Pro to try? 😉 |
Also, I've raised twin boys: I'm trained to focus under extreme conditions 😜 |
@brandonkelly How's this extra wide layout look on the Vision Pro ? :) |
Safari won’t let you resize any wider than this, unfortunately @thupsi! |
I think it doesn't let you because you would knock over you furniture @brandonkelly 😁🤣 |
Updates the global sidebar styling and adds the ability to collapse the global sidebar to get it out of the way. This also adds a max width to the main content area for people with ultra wide screens. The max width is a CSS variable so we can easily tweak it during the beta, or can be tweaked via some custom CSS.
CleanShot.2024-02-02.at.14.47.08.mp4