Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve sidebar and wide screen styling #14281

Merged

Conversation

brianjhanson
Copy link
Contributor

Updates the global sidebar styling and adds the ability to collapse the global sidebar to get it out of the way. This also adds a max width to the main content area for people with ultra wide screens. The max width is a CSS variable so we can easily tweak it during the beta, or can be tweaked via some custom CSS.

CleanShot.2024-02-02.at.14.47.08.mp4

Copy link

linear bot commented Feb 2, 2024

@brandonkelly
Copy link
Member

brandonkelly commented Feb 3, 2024

@brianjhanson Looks really good! Let’s have the global header stay within the same maximum width as everything before it. (The bottom border should still stretch all the way though.)

@AugustMiller
Copy link
Contributor

Brian, you'd asked about things that "appear conditionally" on the call, this morning—the devMode caution tape is the only other thing I can think of. That's probably just a static include, not JS-driven… so probably already handled? 😎

@brianjhanson
Copy link
Contributor Author

Brian, you'd asked about things that "appear conditionally" on the call, this morning—the devMode caution tape is the only other thing I can think of. That's probably just a static include, not JS-driven… so probably already handled? 😎

Thank you! You're correct, that's already handled. I'd kind of like it to be more of an obvious indicator, but that's for another PR.

@brandonkelly brandonkelly merged commit 73831bf into 5.0 Feb 6, 2024
@brandonkelly brandonkelly deleted the feature/cms-1220-improve-sidebar-and-wide-screen-styling branch February 6, 2024 05:11
@wmdhosting
Copy link

wmdhosting commented Feb 6, 2024

just tested.. here is how its looks on bigger screen.. and some bugs
CHROME >> Windows 11

Snag_2b7bb1d

Snag_2b7dd7a
Snag_2b955d2

@brandonkelly
Copy link
Member

@wmdhosting The SEOmatic sidebar bug is another sypmtom of nystudio107/craft-seomatic#1412, which Andrew is working on a fix for.

I’ve fixed the “Entry Types” bug – thanks for reporting that.

Design is subjective but I’m not sure there’s a way we could nicely style Craft for 5060px-wide viewports. Feel free to post a new feature request as a discussion, about making the max-width configurable, though.

@wmdhosting
Copy link

OK :)

Just info, have wide screen and everythign works perfect as it is now.. for main content area

@aelvan
Copy link

aelvan commented Feb 7, 2024

Just another subjective opinion; even at ~2500px I don't really see the point of restricting the max width. Especially for element indexes, where it's actually useful to add a lot of columns and use the available screen estate to get more information at a glance. For the edit page area, it could probably benefit from an even narrower max width, but maybe that can be solved without limiting the element indexes?

CleanShot 2024-02-07 at 09 51 33

Also, the visual hierarchy between the main menu, section menu, and the element index is kind of in limbo at the moment. Partly because the section menu isn't connected to the main menu anymore, and the design for the element index is the only thing that isn't flat. But this is maybe WIP?

@brandonkelly
Copy link
Member

Especially for element indexes, where it's actually useful to add a lot of columns and use the available screen estate to get more information at a glance. For the edit page area, it could probably benefit from an even narrower max width, but maybe that can be solved without limiting the element indexes?

Agree with that. @brianjhanson let’s work on making it possible for certain pages to opt out of the max-width, and take advantage of it on all element index pages.

@brianjhanson brianjhanson mentioned this pull request Feb 7, 2024
@brandonkelly
Copy link
Member

We decided to just remove the maximum content width for now. (#14321)

@thupsi
Copy link

thupsi commented Feb 7, 2024

Well... it was nice while it lasted! IMO the entry editing screen was much more usable, focused, and just plain better looking with the constrained width. Now it's a sea of white again and especially the text fields look wrong with that line length.

But yes, table views with lots of columns warrant special consideration. I think on wide screens there could exist a toggle to turn the constraint on/off. IIRC Notion had somethink like that for tables.

Also maybe the header should not be aligned with the narrow container (that would definitely be the better choice if the content width was variable, to have a constant visual anchor).

Anyway, I don't want to sound negative, I think the new sidebar looks very nice indeed, and the fact that it's collapsible actually helps a lot on narrower viewports (and I suspect that will be a larger demographic than people with huge screens).

@wmdhosting
Copy link

what kind/size of monitor do you have
if you have big monitor .. just resize browser window when you do entry work.. if you have it all the time monitor wide..
Or snap to predefinied size.. most wide monitor have that option

@thupsi
Copy link

thupsi commented Feb 8, 2024

I actually have 3 monitors on my desk, with 3 virtual desktops, so it's like having 9 monitors. As you can imagine I do a lot of window managing, moving, snapping and resizing and I use assisting software for that. Sometimes though, I like to go full screen to focus on stuff.

I also design sites and interfaces daily for a living, some of them with complex forms and UIs, backend dashboards etc. So, I appreciate the pitfalls and complexities of adapting layouts to all kinds of screen sizes. I try to approach things with an algorithmic mindset and sensible constraints, so the UI adapts to the user, not the other way around. It's not easy, I'm not perfect at it, but I enjoy the iterative nature of the process. But now I started bubbling!

Where was I? 😂 Ah yes! I trust the matter of the content width will be improved sometime down the road and I wouldn't dream of imposing my own preferences on the design of a product used by thousands.

@wmdhosting
Copy link

Man you cant be focused with that setup anyway :)

@thupsi
Copy link

thupsi commented Feb 8, 2024

I've found my ways! :) I miss a minimal setup though. Anyone want to gift me a Vision Pro to try? 😉

@thupsi
Copy link

thupsi commented Feb 8, 2024

Also, I've raised twin boys: I'm trained to focus under extreme conditions 😜

@leevigraham
Copy link
Contributor

@brandonkelly How's this extra wide layout look on the Vision Pro ? :)

@brandonkelly
Copy link
Member

Safari won’t let you resize any wider than this, unfortunately @thupsi!

Screenshot from Vision Pro with the Craft CMS dashboard open in a Safari window

@thupsi
Copy link

thupsi commented Feb 11, 2024

I think it doesn't let you because you would knock over you furniture @brandonkelly 😁🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants