Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disallow more actions for asset folders #15302

Closed
wants to merge 1 commit into from
Closed

disallow more actions for asset folders #15302

wants to merge 1 commit into from

Conversation

i-just
Copy link
Contributor

@i-just i-just commented Jul 4, 2024

Description

Disallow “Preview file”, “Download”, “Rename file”, and “Copy reference tag” actions from being performed on folders.

(Tested on v4, and those actions are already disallowed.)

Related issues

#15301

@i-just i-just requested a review from brandonkelly July 4, 2024 15:04
@brandonkelly
Copy link
Member

Root issue was that data-id attributes are no longer getting included at all on folder chips, so the is('[data-id=""]') check wasn’t working anymore (since that is explicitly looking for a data-id attribute set to an empty string). Fixed via d56cf0b.

@brandonkelly brandonkelly deleted the bugfix/15301-restrict-folder-actions branch July 5, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandonkelly brandonkelly Awaiting requested review from brandonkelly

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@i-just @brandonkelly