Rework consul discovery logic #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Discovery behavior matches the native zookeeper HA hive setup of selecting only one Hive instance for the whole hue instance - Consul logic is integrated into get_query_server_config instead of trying to update the hive host/port at the last moment - Fix duplicated imports
mliroz
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change brings the get() function to be the same as the upstream/cloudera version.
What changes are made to get_query_server_config() are new branches in conditional statements, and does not modify any lines existing in the upstream. This should result in a diff between upstream and our fork that consists entirely in added lines