Problem: (fix #1177) chain-abci doesn't work with Tendermint v0.33.* #1441

linfeng-crypto · 2020-04-15T08:10:20Z

solution:

updata abci vertion to 0.7
use the tendermint-rs verion v0.33

tomtau · 2020-04-15T08:11:42Z

bors try

bors · 2020-04-15T08:20:36Z

try

Build failed:

drone-hw/push

tomtau

integration tests fail:

ERROR: Failed to create node: Error reading GenesisDoc at /drone/src/integration-tests/data/node0/tendermint/config/genesis.json: EvidenceParams.MaxAge must be greater than 0. Got 0
209	ERROR: Failed to create node: Error reading GenesisDoc at /drone/src/integration-tests/data/node0/tendermint/config/genesis.json: EvidenceParams.MaxAge must be greater than 0. Got 0
210	ERROR: Failed to create node: Error reading GenesisDoc at /drone/src/integration-tests/data/node0/tendermint/config/genesis.json: EvidenceParams.MaxAge must be greater than 0. Got 0
211	ERROR: Failed to create node: Error reading GenesisDoc at /drone/src/integration-tests/data/node0/tendermint/config/genesis.json: EvidenceParams.MaxAge must be greater than 0. Got 0
212	ERROR: Failed to create node: Error reading GenesisDoc at /drone/src/integration-tests/data/node0/tendermint/config/genesis.json: EvidenceParams.MaxAge must be greater than 0. Got 0
213	ERROR: Failed to create node: Error reading GenesisDoc at /drone/src/integration-tests/data/node0/tendermint/config/genesis.json: EvidenceParams.MaxAge must be greater than 0. Got 0
214	ERROR: Failed to create node: Error reading GenesisDoc at /drone/src/integration-tests/data/node0/tendermint/config/genesis.json: EvidenceParams.MaxAge must be greater than 0. Got 0
215	ERROR: Failed to create node: Error reading GenesisDoc at /drone/src/integration-tests/data/node0/tendermint/config/genesis.json: EvidenceParams.MaxAge must be greater than 0. Got 0
216	ERROR: Failed to create node: Error reading GenesisDoc at /drone/src/integration-tests/data/node0/tendermint/config/genesis.json: EvidenceParams.MaxAge must be greater than 0. Got 0
217	ERROR: Failed to create node: Error reading GenesisDoc at /drone/src/integration-tests/data/node0/tendermint/config/genesis.json: EvidenceParams.MaxAge must be greater than 0. Got 0
218	ERROR: Failed to create node: Error reading GenesisDoc at /drone/src/integration-tests/data/node0/tendermint/config/genesis.json: EvidenceParams.MaxAge must be greater than 0. Got 0
219	ERROR: Failed to create node: Error reading GenesisDoc at /drone/src/integration-tests/data/node0/tendermint/config/genesis.json: EvidenceParams.MaxAge must be greater than 0. Got 0
220

tomtau · 2020-04-15T08:13:17Z

chain-core/src/init/config.rs

@@ -80,7 +80,7 @@ impl fmt::Display for DistributionError {

 /// Initial configuration ("app_state" in genesis.json of Tendermint config)
 /// TODO: reward/treasury config, extra validator config...
-#[derive(Debug, PartialEq, Eq, Clone)]
+#[derive(Debug, PartialEq, Eq, Default, Clone)]


why are defaults added to chain-core?

there seems to be an error when deserializing something if not add Default, I remember, I'll check again.

tomtau · 2020-04-15T08:14:40Z

client-common/src/tendermint/lite.rs

@@ -8,7 +8,7 @@ use crate::Result as CommonResult;

 ///
 #[derive(Clone, Debug, Deserialize, Serialize)]
-pub struct TrustedState(pub(crate) Option<lite::TrustedState<SignedHeader, Header>>);
+pub struct TrustedState(pub Option<lite::TrustedState<SignedHeader, Header>>);


why not pub(crate)?

Oh, that just used to get the Option<...> to debug, I'll rollback.

tomtau · 2020-04-15T08:15:36Z

client-common/src/tendermint/rpc_client/async_rpc_client.rs

@@ -147,7 +147,7 @@ impl AsyncRpcClient {
    /// TODO: Usage of `Vec` can be removed once we execute it in a purely async context
    pub async fn call_batch<T>(&self, batch_params: &[(&str, Vec<Value>)]) -> Result<Vec<T>>
    where
-        for<'de> T: Deserialize<'de>,
+        for<'de> T: Deserialize<'de> + std::fmt::Debug,


is that debug needed?

just for debugging, I'll remove.

tomtau · 2020-04-15T08:16:19Z

client-common/src/tendermint/rpc_client/sync_rpc_client.rs

+            .map(|height| {
+                (
+                    "validators",
+                    vec![json!(height.to_string()), json!("0"), json!("100")],


what's that 0 and 100? paging?

yes, the rpc call changed, if not add 0, 100, there will be an error.

page and per_page? I think we shouldn't have an assumptions of 100 validators?

https://docs.tendermint.com/master/rpc/#/Info/validators

default is 30, the max is 100, I don't know what value should be used here, I used the max value.

linfeng-crypto · 2020-04-15T08:58:18Z

integration tests fail:

ERROR: Failed to create node: Error reading GenesisDoc at /drone/src/integration-tests/data/node0/tendermint/config/genesis.json: EvidenceParams.MaxAge must be greater than 0. Got 0
209	ERROR: Failed to create node: Error reading GenesisDoc at /drone/src/integration-tests/data/node0/tendermint/config/genesis.json: EvidenceParams.MaxAge must be greater than 0. Got 0
210	ERROR: Failed to create node: Error reading GenesisDoc at /drone/src/integration-tests/data/node0/tendermint/config/genesis.json: EvidenceParams.MaxAge must be greater than 0. Got 0
211	ERROR: Failed to create node: Error reading GenesisDoc at /drone/src/integration-tests/data/node0/tendermint/config/genesis.json: EvidenceParams.MaxAge must be greater than 0. Got 0
212	ERROR: Failed to create node: Error reading GenesisDoc at /drone/src/integration-tests/data/node0/tendermint/config/genesis.json: EvidenceParams.MaxAge must be greater than 0. Got 0
213	ERROR: Failed to create node: Error reading GenesisDoc at /drone/src/integration-tests/data/node0/tendermint/config/genesis.json: EvidenceParams.MaxAge must be greater than 0. Got 0
214	ERROR: Failed to create node: Error reading GenesisDoc at /drone/src/integration-tests/data/node0/tendermint/config/genesis.json: EvidenceParams.MaxAge must be greater than 0. Got 0
215	ERROR: Failed to create node: Error reading GenesisDoc at /drone/src/integration-tests/data/node0/tendermint/config/genesis.json: EvidenceParams.MaxAge must be greater than 0. Got 0
216	ERROR: Failed to create node: Error reading GenesisDoc at /drone/src/integration-tests/data/node0/tendermint/config/genesis.json: EvidenceParams.MaxAge must be greater than 0. Got 0
217	ERROR: Failed to create node: Error reading GenesisDoc at /drone/src/integration-tests/data/node0/tendermint/config/genesis.json: EvidenceParams.MaxAge must be greater than 0. Got 0
218	ERROR: Failed to create node: Error reading GenesisDoc at /drone/src/integration-tests/data/node0/tendermint/config/genesis.json: EvidenceParams.MaxAge must be greater than 0. Got 0
219	ERROR: Failed to create node: Error reading GenesisDoc at /drone/src/integration-tests/data/node0/tendermint/config/genesis.json: EvidenceParams.MaxAge must be greater than 0. Got 0
220

we need to use tendermint v0.33 binary, the genesis also different with the old version.

calvinaco · 2020-04-15T09:01:09Z

client-common/src/tendermint/rpc_client/sync_rpc_client.rs

+            .map(|height| {
+                (
+                    "validators",
+                    vec![json!(height.to_string()), json!("0"), json!("100")],


page and per_page? I think we shouldn't have an assumptions of 100 validators?

calvinaco · 2020-04-15T09:06:51Z

client-common/src/tendermint/types/block_results.rs

-            };
-
+            let response_str = r#"{"height": "37", "txs_results": [{"code": 0, "data": null, "log": "", "info": "", "gasWanted": "0", "gasUsed": "0", "events": [{"type": "valid_txs", "attributes": [{"key": "ZmVl", "value": "MC4wMDAwMDMwNw=="}, {"key": "YWNjb3VudA==", "value": "MHgzMzUwMmVkMzlkMGM0ZTIwNDRmYjM3ZmRjZDUxNjE0OTNmNTkwMGMz"}, {"key": "dHhpZA==", "value": "ZjFmNzNkNmFjZWMyMTExOGRkMWUzNmY2ODRhYWUyMmM2Y2IxN2ZjNTFhZGEzNGEzNDIzMDlkNTMxY2I5YmU4ZA=="}]}], "codespace": ""}], "begin_block_events": null, "end_block_events": [{"type": "block_filter", "attributes": [{"key": "ZXRoYmxvb20=", "value": "AAAAAAAAAAAAAAAAAgAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAEAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAgAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA=="}]}], "validator_updates": null, "consensus_param_updates": null}"#;
+            //            let response_str = r#"


Is this comment still needed?

no, I'll remove it.

calvinaco · 2020-04-15T09:07:09Z

client-common/src/tendermint/types/block_results.rs

-            assert!(result.is_ok());
-            assert_eq!(true, result.unwrap());
-        }
-


Any reason to remove the following test cases?

yeah, most of the test cases in this file is testing the invalid value of Attribute in the BlockResults and BlockResults defined in this file.

Now, we use BlockResultsResponse directly which defined in tendermint-rs, and we query tendermint to get the BlockResultsResponse, I don't think tendermint will give us one which value is invalid.

calvinaco · 2020-04-15T09:11:21Z

client-core/src/service/sync_state_service.rs

+        let s1 = serde_json::to_string_pretty(&state).unwrap();
+        let state2: std::result::Result<SyncState, _> = serde_json::from_str(&s1);
+        let bytes = state.encode();
+        let _state1 = SyncState::decode(&mut bytes.as_slice()).unwrap();


Where is the assertion? And perhaps give some more meaningful variable names for readability.

calvinaco · 2020-04-15T09:11:51Z

client-core/src/wallet/syncer.rs

@@ -327,7 +328,8 @@ impl<'a, S: SecureStorage, C: Client, D: TxDecryptor, F: FnMut(ProgressReport) -

            let range = chunk.collect::<Vec<u64>>();

-            if self.env.enable_fast_forward {
+            //if self.env.enable_fast_forward {
+            if true {


Is this for debug?

yes, I'll remove it

calvinaco · 2020-04-15T09:12:36Z

client-rpc/src/program.rs

@@ -73,7 +73,7 @@ pub struct Options {

 #[allow(dead_code)]
 pub fn run_cli() {
-    env_logger::init();
+    //    env_logger::init();


Any reason to disable env logger?

It's a mistake. I'll recover it.

yihuang · 2020-04-15T09:46:44Z

integration tests fail:

ERROR: Failed to create node: Error reading GenesisDoc at /drone/src/integration-tests/data/node0/tendermint/config/genesis.json: EvidenceParams.MaxAge must be greater than 0. Got 0
209	ERROR: Failed to create node: Error reading GenesisDoc at /drone/src/integration-tests/data/node0/tendermint/config/genesis.json: EvidenceParams.MaxAge must be greater than 0. Got 0
210	ERROR: Failed to create node: Error reading GenesisDoc at /drone/src/integration-tests/data/node0/tendermint/config/genesis.json: EvidenceParams.MaxAge must be greater than 0. Got 0
211	ERROR: Failed to create node: Error reading GenesisDoc at /drone/src/integration-tests/data/node0/tendermint/config/genesis.json: EvidenceParams.MaxAge must be greater than 0. Got 0
212	ERROR: Failed to create node: Error reading GenesisDoc at /drone/src/integration-tests/data/node0/tendermint/config/genesis.json: EvidenceParams.MaxAge must be greater than 0. Got 0
213	ERROR: Failed to create node: Error reading GenesisDoc at /drone/src/integration-tests/data/node0/tendermint/config/genesis.json: EvidenceParams.MaxAge must be greater than 0. Got 0
214	ERROR: Failed to create node: Error reading GenesisDoc at /drone/src/integration-tests/data/node0/tendermint/config/genesis.json: EvidenceParams.MaxAge must be greater than 0. Got 0
215	ERROR: Failed to create node: Error reading GenesisDoc at /drone/src/integration-tests/data/node0/tendermint/config/genesis.json: EvidenceParams.MaxAge must be greater than 0. Got 0
216	ERROR: Failed to create node: Error reading GenesisDoc at /drone/src/integration-tests/data/node0/tendermint/config/genesis.json: EvidenceParams.MaxAge must be greater than 0. Got 0
217	ERROR: Failed to create node: Error reading GenesisDoc at /drone/src/integration-tests/data/node0/tendermint/config/genesis.json: EvidenceParams.MaxAge must be greater than 0. Got 0
218	ERROR: Failed to create node: Error reading GenesisDoc at /drone/src/integration-tests/data/node0/tendermint/config/genesis.json: EvidenceParams.MaxAge must be greater than 0. Got 0
219	ERROR: Failed to create node: Error reading GenesisDoc at /drone/src/integration-tests/data/node0/tendermint/config/genesis.json: EvidenceParams.MaxAge must be greater than 0. Got 0
220

we need to use tendermint v0.33 binary, the genesis also different with the old version.

Can you modify the tendermint version number in the Dockerfile in root directory, line 16 and line 44.

yihuang · 2020-04-15T09:50:51Z

integration-tests/bot/chainbot.py

@@ -348,7 +348,8 @@ async def gen_genesis(cfg):
                "time_iota_ms": "1000"
            },
            "evidence": {
-                "max_age": "100000"
+               "max_age_num_blocks": "100000",
+               "max_age_duration": "172800000000000"


What's the unit of max_age_duration, I think we have an assumption that unbonding_period > max_age_duration.

I use the default value of the new tendermint's config. we can find it in change log:
https://github.com/tendermint/tendermint/blob/master/CHANGELOG.md

yihuang · 2020-04-15T09:55:22Z

test-common/src/block_generator.rs

-        .expect("verify failed");
+        */
+
+        //FIXME: use new interface in tendermint v0.33 instead of verify_single


The lite client API already migrated to tendermint-rs master, what's the difference in v0.33 on this?

v0.33 removed the interface and add some other similar interfaces, but the arguments are different, the logic also has some difference, I'm not clear about the logic and I think this function is very important, so I add FIXME here, maybe we can fix it in other PR.

v0.33 removed the interface and add some other similar interfaces, but the arguments are different, the logic also has some difference, I'm not clear about the logic and I think this function is very important, so I add FIXME here, maybe we can fix it in other PR.

I think this API still exists with the same signature?
https://github.com/crypto-com/tendermint-rs/blob/v0.33/tendermint/src/lite/verifier.rs#L228

same here https://github.com/informalsystems/tendermint-rs/blob/tendermint/v0.33/tendermint/src/lite/verifier.rs#L228 ?

yeah, I'll check again.

I need to fix gen_block() to make this test pass.

codecov · 2020-04-16T00:07:34Z

Codecov Report

Merging #1441 into master will increase coverage by 0.13%.
The diff coverage is 80.14%.

@@            Coverage Diff             @@
##           master    #1441      +/-   ##
==========================================
+ Coverage   63.43%   63.56%   +0.13%     
==========================================
  Files         159      159              
  Lines       21188    21028     -160     
==========================================
- Hits        13441    13367      -74     
+ Misses       7747     7661      -86

Impacted Files	Coverage Δ
chain-abci/src/app/end_block.rs	`100.00% <ø> (ø)`
client-cli/src/command.rs	`0.00% <0.00%> (ø)`
...ommon/src/tendermint/rpc_client/sync_rpc_client.rs	`0.00% <0.00%> (ø)`
client-core/src/cipher/default.rs	`0.00% <0.00%> (ø)`
client-core/src/wallet/default_wallet_client.rs	`43.46% <0.00%> (ø)`
client-rpc/src/rpc/multisig_rpc.rs	`32.86% <0.00%> (ø)`
cro-clib/src/transaction.rs	`0.00% <0.00%> (ø)`
client-rpc/src/rpc/wallet_rpc.rs	`62.99% <40.00%> (+0.49%)`	⬆️
...lient-common/src/tendermint/unauthorized_client.rs	`15.78% <50.00%> (ø)`
...work/src/network_ops/default_network_ops_client.rs	`75.69% <50.00%> (-0.09%)`	⬇️
... and 13 more

tomtau · 2020-04-16T03:14:00Z

bors try

bors · 2020-04-16T03:22:33Z

try

Build failed:

drone-hw/push

yihuang · 2020-04-16T03:28:03Z

client-common/src/tendermint/types.rs

@@ -24,7 +24,7 @@ pub use tendermint::{
 };

 /// crypto-com instantiated genesis type
-pub type Genesis = GenericGenesis<InitConfig>;
+pub type Genesis = GenericGenesis<Option<InitConfig>>;


Is this Option needed?

Before in tendermint-rs, it had a field Option<AppState> -- now the type changed to AppState, so it'd require Default implementation AppState / InitConfig.
I think Option may be clearer, as it'll be immediate that the app_state was missing or incorrect in json rather than some arbitrary default value?

yihuang · 2020-04-16T03:29:11Z

client-core/src/service/sync_state_service.rs


 /// key space of wallet sync state
 const KEYSPACE: &str = "core_wallet_sync";

 /// Sync state for wallet
-#[derive(Debug, Encode, Decode)]
+#[derive(Debug, Serialize, Deserialize, Encode, Decode)]


Where are these two instances used?

It's for debugging, I'll remove.

tomtau · 2020-04-16T03:48:30Z

Dockerfile

@@ -13,7 +13,7 @@ RUN set -e; \
    apt-get install -y libzmq3-dev libssl1.1 libprotobuf10 libsgx-launch libsgx-urts libsgx-epid libsgx-quote-ex; \
    rm -rf /var/lib/apt/lists/*

-COPY --from=tendermint/tendermint:v0.32.9 /usr/bin/tendermint /usr/bin/tendermint


Line 44 also needs to be changed?

yes, I'll do that.

yihuang · 2020-04-16T03:48:59Z

test-common/src/block_generator.rs

+            app_hash: Hash::new(hash::Algorithm::Sha256, &app_hash)
+                .unwrap()
+                .as_bytes()
+                .to_vec(),


Suggested change

app_hash: Hash::new(hash::Algorithm::Sha256, &app_hash)

.unwrap()

.as_bytes()

.to_vec(),

app_hash: app_hash.to_vec(),

yihuang · 2020-04-16T03:49:51Z

test-common/src/block_generator.rs

+            app_hash: Hash::new(hash::Algorithm::Sha256, &last_state.last_apphash)
+                .unwrap()
+                .as_bytes()
+                .to_vec(),


Suggested change

app_hash: Hash::new(hash::Algorithm::Sha256, &last_state.last_apphash)

.unwrap()

.as_bytes()

.to_vec(),

app_hash: last_state.last_apphash.to_vec(),

yihuang

I think the lite client API is not changed, so the lite client code might not need to change
Several maybe not used instance
Other minor changes.

tomtau · 2020-04-16T06:57:25Z

bors retry

bors · 2020-04-16T07:06:17Z

try

Build failed:

drone-hw/push

tomtau · 2020-04-16T07:17:53Z

I guess the images on docker hub will need to be updated, I'll try

bors · 2020-04-16T08:00:03Z

try

Build failed:

drone-hw/push

tomtau

multinode integration test fails:

Traceback (most recent call last):
110	  File "./multinode/join_test.py", line 45, in <module>
111	    wait_for_validators(rpc, 3)
112	  File "/drone/src/integration-tests/multinode/common.py", line 34, in wait_for_validators
113	    n = len(rpc.chain.validators()['validators'])
114	  File "/drone/src/integration-tests/bot/chainrpc.py", line 283, in validators
115	    return self.call_chain('validators', str(height) if height is not None else None)
116	  File "/drone/src/integration-tests/bot/chainrpc.py", line 62, in call_chain
117	    rsp = request(self.chain_rpc_url, method, *args, **kwargs)
118	  File "/drone/src/drone/venv/lib/python3.8/site-packages/jsonrpcclient/__init__.py", line 8, in request
119	    return HTTPClient(endpoint).request(*args, **kwargs)
120	  File "/drone/src/drone/venv/lib/python3.8/site-packages/apply_defaults/decorators.py", line 13, in wrapper
121	    return function(self, *args, **kwargs)
122	  File "/drone/src/drone/venv/lib/python3.8/site-packages/jsonrpcclient/client.py", line 229, in request
123	    return self.send(
124	  File "/drone/src/drone/venv/lib/python3.8/site-packages/apply_defaults/decorators.py", line 13, in wrapper
125	    return function(self, *args, **kwargs)
126	  File "/drone/src/drone/venv/lib/python3.8/site-packages/jsonrpcclient/client.py", line 177, in send
127	    raise ReceivedErrorResponseError(response.data)
128	jsonrpcclient.exceptions.ReceivedErrorResponseError: Invalid params

yihuang · 2020-04-16T18:10:29Z

.drone.yml

@@ -8,23 +8,23 @@ platform:

 steps:
 - name: build
-  image: cryptocom/chain-test:v1.1.1
+  image: cryptocom/chain-test:latest


We better to increment the version number after pushed the image, otherwise, the image might not get updated.

It does not matter, Tomas can cover for that.

tomtau · 2020-04-17T01:08:39Z

bors retry

bors · 2020-04-17T01:38:54Z

try

Build failed:

drone-hw/push

linfeng-crypto · 2020-04-17T01:41:24Z

multinode integration test fails:

Traceback (most recent call last):
110	  File "./multinode/join_test.py", line 45, in <module>
111	    wait_for_validators(rpc, 3)
112	  File "/drone/src/integration-tests/multinode/common.py", line 34, in wait_for_validators
113	    n = len(rpc.chain.validators()['validators'])
114	  File "/drone/src/integration-tests/bot/chainrpc.py", line 283, in validators
115	    return self.call_chain('validators', str(height) if height is not None else None)
116	  File "/drone/src/integration-tests/bot/chainrpc.py", line 62, in call_chain
117	    rsp = request(self.chain_rpc_url, method, *args, **kwargs)
118	  File "/drone/src/drone/venv/lib/python3.8/site-packages/jsonrpcclient/__init__.py", line 8, in request
119	    return HTTPClient(endpoint).request(*args, **kwargs)
120	  File "/drone/src/drone/venv/lib/python3.8/site-packages/apply_defaults/decorators.py", line 13, in wrapper
121	    return function(self, *args, **kwargs)
122	  File "/drone/src/drone/venv/lib/python3.8/site-packages/jsonrpcclient/client.py", line 229, in request
123	    return self.send(
124	  File "/drone/src/drone/venv/lib/python3.8/site-packages/apply_defaults/decorators.py", line 13, in wrapper
125	    return function(self, *args, **kwargs)
126	  File "/drone/src/drone/venv/lib/python3.8/site-packages/jsonrpcclient/client.py", line 177, in send
127	    raise ReceivedErrorResponseError(response.data)
128	jsonrpcclient.exceptions.ReceivedErrorResponseError: Invalid params

It seems that the validators rpc parameters is not fixed in chainrpc.py, I'll check.

tomtau · 2020-04-17T01:58:45Z

bors retry

bors · 2020-04-17T03:04:56Z

try

Build failed:

drone-hw/push

tomtau

integration tests still fail + there's a conflict with the latest master

leejw51crypto

lgtm

tomtau · 2020-04-17T10:28:54Z

bors try

bors · 2020-04-17T10:41:46Z

try

Build failed:

drone-hw/push

tomtau · 2020-04-17T10:50:16Z


[2020-04-17T10:41:41Z ERROR client_rpc::server] Tendermint RPC error: Error while calling tendermint RPC call
--
484 | => Unable to deserialize `block_results` from JSON-RPC response for params: [String("6")]
485

tomtau · 2020-04-20T07:29:08Z

bors try

tomtau

@linfeng-crypto can you squash the commits?

bors · 2020-04-20T09:20:11Z

try

Build succeeded:

…t v0.33.* * update tendermint version in Dockerfile * fix test case, remove useless code * update docker image version and signature in .drone.yaml * fix check_lite_client test case * fix parameters for validators rpc in chainprc.py * remove useless function in block_generator * update tendermint-rs and fix a data error in multi_node test

tomtau · 2020-04-21T05:32:27Z

bors r+

bors · 2020-04-21T06:14:29Z

Build succeeded:

linfeng-crypto requested review from calvinaco, devashishdxt and tomtau as code owners April 15, 2020 08:10

tomtau requested review from yihuang and leejw51crypto April 15, 2020 08:11

bors bot added a commit that referenced this pull request Apr 15, 2020

Try #1441:

ae1603f

tomtau suggested changes Apr 15, 2020

View reviewed changes

linfeng-crypto force-pushed the issue-1177 branch from a8ba232 to 7db383d Compare April 15, 2020 08:43

calvinaco suggested changes Apr 15, 2020

View reviewed changes

yihuang reviewed Apr 15, 2020

View reviewed changes

bors bot added a commit that referenced this pull request Apr 16, 2020

Try #1441:

645958a

yihuang reviewed Apr 16, 2020

View reviewed changes

tomtau self-requested a review April 16, 2020 03:46

tomtau reviewed Apr 16, 2020

View reviewed changes

yihuang reviewed Apr 16, 2020

View reviewed changes

yihuang suggested changes Apr 16, 2020

View reviewed changes

bors bot added a commit that referenced this pull request Apr 16, 2020

Try #1441:

febb980

tomtau self-requested a review April 16, 2020 08:16

tomtau suggested changes Apr 16, 2020

View reviewed changes

yihuang reviewed Apr 16, 2020

View reviewed changes

yihuang approved these changes Apr 16, 2020

View reviewed changes

bors bot added a commit that referenced this pull request Apr 17, 2020

Try #1441:

2d1d6fe

bors bot added a commit that referenced this pull request Apr 17, 2020

Try #1441:

a5947ea

tomtau self-requested a review April 17, 2020 06:22

tomtau suggested changes Apr 17, 2020

View reviewed changes

leejw51crypto approved these changes Apr 17, 2020

View reviewed changes

linfeng-crypto force-pushed the issue-1177 branch from 63b31ef to e5005ae Compare April 17, 2020 09:34

bors bot added a commit that referenced this pull request Apr 17, 2020

Try #1441:

5fbb213

bors bot added a commit that referenced this pull request Apr 20, 2020

Try #1441:

82ac8b6

tomtau self-requested a review April 20, 2020 08:07

tomtau suggested changes Apr 20, 2020

View reviewed changes

linfeng-crypto force-pushed the issue-1177 branch from 5fe89a2 to 696d8cf Compare April 21, 2020 01:46

bors bot merged commit ea563c3 into crypto-com:master Apr 21, 2020

Problem: (fix #1177) chain-abci doesn't work with Tendermint v0.33.* #1441

Problem: (fix #1177) chain-abci doesn't work with Tendermint v0.33.* #1441

Conversation

linfeng-crypto commented Apr 15, 2020

tomtau commented Apr 15, 2020

bors bot commented Apr 15, 2020

try

tomtau left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

linfeng-crypto Apr 15, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

linfeng-crypto commented Apr 15, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yihuang commented Apr 15, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yihuang Apr 15, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Apr 16, 2020 • edited Loading

Codecov Report

tomtau commented Apr 16, 2020

bors bot commented Apr 16, 2020

try

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yihuang left a comment • edited Loading

Choose a reason for hiding this comment

tomtau commented Apr 16, 2020

bors bot commented Apr 16, 2020

try

tomtau commented Apr 16, 2020

bors bot commented Apr 16, 2020

try

tomtau left a comment

Choose a reason for hiding this comment

yihuang Apr 16, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tomtau commented Apr 17, 2020

bors bot commented Apr 17, 2020

try

linfeng-crypto commented Apr 17, 2020

tomtau commented Apr 17, 2020

bors bot commented Apr 17, 2020

try

tomtau left a comment

Choose a reason for hiding this comment

leejw51crypto left a comment

Choose a reason for hiding this comment

linfeng-crypto Apr 15, 2020 •

edited

Loading

linfeng-crypto commented Apr 15, 2020 •

edited

Loading

yihuang Apr 15, 2020 •

edited

Loading

codecov bot commented Apr 16, 2020 •

edited

Loading

yihuang left a comment •

edited

Loading

yihuang Apr 16, 2020 •

edited

Loading