This repository has been archived by the owner on Jul 27, 2022. It is now read-only.
Problem (Fix #1523): sync state deserialization fails when nil vote happens #1524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihuang
force-pushed
the
master
branch
2 times, most recently
from
6830006 to
579d29b
Compare
…nil vote happens Solution: - Make parse_non_empty_id parse null in tendermint-rs
Codecov Report
@@ Coverage Diff @@
## master #1524 +/- ##
=======================================
Coverage 65.77% 65.78%
=======================================
Files 161 161
Lines 21808 21818 +10
=======================================
+ Hits 14345 14353 +8
- Misses 7463 7465 +2
|
|
Build succeeded: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution:
Related upstream PR: informalsystems/tendermint-rs#98