Skip to content
This repository has been archived by the owner on Jul 27, 2022. It is now read-only.

Problem: trusted_state serialization/deserailzation not symmetric #694

Merged
merged 1 commit into from
Dec 17, 2019
Merged

Problem: trusted_state serialization/deserailzation not symmetric #694

merged 1 commit into from
Dec 17, 2019

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Dec 17, 2019

Solution:

  • Fixed deserailzation code in tendermint-rs.
  • Added unit test to verify.

tomtau
tomtau approved these changes Dec 17, 2019
View reviewed changes
Copy link
Contributor

@tomtau tomtau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@codecov
Copy link

codecov bot commented Dec 17, 2019 •
edited
Loading

Codecov Report

Merging #694 into master will increase coverage by 0.05%.
The diff coverage is 92.85%.

@@            Coverage Diff            @@
##           master    #694      +/-   ##
=========================================
+ Coverage   70.14%   70.2%   +0.05%     
=========================================
  Files         131     131              
  Lines       16558   16571      +13     
=========================================
+ Hits        11614   11633      +19     
+ Misses       4944    4938       -6
Impacted Files Coverage Δ
client-common/src/tendermint/lite.rs 86.66% <0%> (ø) ⬆️
client-core/src/service/sync_state_service.rs 84.33% <100%> (+2.9%) ⬆️
chain-core/src/tx/fee/mod.rs 88.17% <0%> (+0.49%) ⬆️
client-common/src/storage.rs 93.97% <0%> (+6.02%) ⬆️

@bors
Copy link
Contributor

bors bot commented Dec 17, 2019

This PR was included in a batch with a merge conflict, it will be automatically retried

1 similar comment
@bors
Copy link
Contributor

bors bot commented Dec 17, 2019

This PR was included in a batch with a merge conflict, it will be automatically retried

@yihuang yihuang force-pushed the fix_trusted_state_deserialization branch from cf252e9 to 39a4c17 Compare December 17, 2019 10:14
@bors
Copy link
Contributor

bors bot commented Dec 17, 2019

Canceled

@yihuang
Copy link
Collaborator Author

yihuang commented Dec 17, 2019

Conflicts fixed and rebased.

@yihuang
Problem: trusted_state serialization/deserailzation not symmetric
9abf231 
Solution:
- Fixed deserailzation code in tendermint-rs.
- Added unit test to verify.
@yihuang yihuang force-pushed the fix_trusted_state_deserialization branch from 39a4c17 to 9abf231 Compare December 17, 2019 10:16
@tomtau
Copy link
Contributor

tomtau commented Dec 17, 2019

bors r+

bors bot added a commit that referenced this pull request Dec 17, 2019
@bors @yihuang
Merge #694
361c7cf 
694: Problem: trusted_state serialization/deserailzation not symmetric r=tomtau a=yihuang

Solution:
- Fixed deserailzation code in tendermint-rs.
- Added unit test to verify.

Co-authored-by: yihuang <[email protected]>
@bors
Copy link
Contributor

bors bot commented Dec 17, 2019

Build succeeded

@bors bors bot merged commit 9abf231 into crypto-com:master Dec 17, 2019
@yihuang yihuang deleted the fix_trusted_state_deserialization branch December 19, 2019 08:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tomtau tomtau tomtau approved these changes

@devashishdxt devashishdxt devashishdxt approved these changes

@calvinaco calvinaco Awaiting requested review from calvinaco calvinaco is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yihuang @tomtau @devashishdxt