This repository has been archived by the owner on Jul 27, 2022. It is now read-only.
Problem:(CRO-661) not enough logging in debug enclave execution #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linfeng-crypto
requested review from
calvinaco,
devashishdxt and
tomtau
as code owners
bors bot
added a commit
that referenced
this pull request
Dec 27, 2019
695: Problem:(CRO-557) no way to import transactions (without a view key) r=devashishdxt a=linfeng-crypto solution: - add a interface `export_tx` for sender to get the plain transaction - add a interface `import_tx` for receiver to import the plain transaction and get the output UTXO 740: Problem:(CRO-661) not enough logging in debug enclave execution r=devashishdxt a=linfeng-crypto solution: add some logs. Co-authored-by: linfeng <[email protected]>
Build failed (retrying...) |
bors bot
added a commit
that referenced
this pull request
Dec 27, 2019
740: Problem:(CRO-661) not enough logging in debug enclave execution r=devashishdxt a=linfeng-crypto solution: add some logs. Co-authored-by: linfeng <[email protected]>
Build failed |
devashishdxt
suggested changes
Dec 27, 2019
There was a problem hiding this comment.
Fix these formatting errors:
https://travis-ci.org/crypto-com/chain/jobs/629881801#L1408
calvinaco
approved these changes
Dec 27, 2019
linfeng-crypto
force-pushed
the
CRO-661
branch
from
006ed0c to
5648980
Compare
Codecov Report
@@ Coverage Diff @@
## master #740 +/- ##
==========================================
- Coverage 69.71% 69.12% -0.59%
==========================================
Files 131 132 +1
Lines 16745 16896 +151
==========================================
+ Hits 11674 11680 +6
- Misses 5071 5216 +145
|
linfeng-crypto
force-pushed
the
CRO-661
branch
from
5648980 to
5b904c9
Compare
tomtau
suggested changes
Jan 2, 2020
|
bors try |
tryBuild failed |
|
bors retry |
|
bors try- |
linfeng-crypto
force-pushed
the
CRO-661
branch
from
5b904c9 to
6685bce
Compare
tomtau
suggested changes
Jan 3, 2020
There was a problem hiding this comment.
looks ok -- not sure if all the log levels are appropriate, but we can possibly fix that later if it's too chatty.
just one small formatting issue to fix -- https://travis-ci.org/crypto-com/chain/jobs/632149160#L1502
cargo fmt should do
linfeng-crypto
force-pushed
the
CRO-661
branch
from
6685bce to
bba7fd6
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jan 3, 2020
740: Problem:(CRO-661) not enough logging in debug enclave execution r=tomtau a=linfeng-crypto solution: add some logs. Co-authored-by: linfeng <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solution: add some logs.