Problem (Fix #777): Order of client list address api is not sorted by creation order.

[yihuang]

Solution:

• change BTreeSet to IndexSet

This is required by new integration tests, also more intuitive to user.

[tomtau]

isn't the order stable with TreeSet? Always sorted?

[devashishdxt]

isn't the order stable with TreeSet? Always sorted?

We can also use IndexSet if we want to preserve insertion order in set.

[yihuang]

isn't the order stable with TreeSet? Always sorted?

I need it sorted by creation order, just edited the title.

[yihuang]

isn't the order stable with TreeSet? Always sorted?

We can also use IndexSet if we want to preserve insertion order in set.

IndexSet is good as long as we don't need to remove item, it seems we won't have removal requirement in the future?

[devashishdxt]

isn't the order stable with TreeSet? Always sorted?

We can also use IndexSet if we want to preserve insertion order in set.

IndexSet is good as long as we don't need to remove, it seems we won't have removal requirement?

I can only foresee clear() (highly improbable that we'll need this) which is ok with IndexSet.

[codecov]

Codecov Report

Merging #928 into master will increase coverage by 0.02%.
The diff coverage is 77.35%.

@@            Coverage Diff             @@
##           master     #928      +/-   ##
==========================================
+ Coverage   68.32%   68.34%   +0.02%     
==========================================
  Files         133      133              
  Lines       17534    17562      +28     
==========================================
+ Hits        11980    12003      +23     
- Misses       5554     5559       +5

Impacted Files	Coverage Δ
client-core/src/wallet/syncer.rs	61.12% <100%> (+0.12%)	⬆️
client-common/src/key/public_key.rs	78.51% <100%> (ø)	⬆️
client-rpc/src/rpc/wallet_rpc.rs	62.98% <28.57%> (-0.14%)	⬇️
client-core/src/wallet/default_wallet_client.rs	43.89% <33.33%> (ø)	⬆️
client-core/src/service/wallet_service.rs	86.73% <87.5%> (+0.26%)	⬆️
chain-core/src/tx/fee/mod.rs	87.68% <0%> (-0.5%)	⬇️

[yihuang]

isn't the order stable with TreeSet? Always sorted?

We can also use IndexSet if we want to preserve insertion order in set.

IndexSet is good as long as we don't need to remove, it seems we won't have removal requirement?

I can only foresee clear() (highly improbable that we'll need this) which is ok with IndexSet.

Done, changed to use IndexSet.

[tomtau]

bors r+

[bors]

Build succeeded

• continuous-integration/drone/push
• continuous-integration/travis-ci/push