This repository has been archived by the owner on Jul 27, 2022. It is now read-only.
Problem(fix #882):required tx-query environment vaiables are unchecked #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e unchecked Solution: add the environment check when the tx-query starts.
linfeng-crypto
requested review from
calvinaco,
devashishdxt and
tomtau
as code owners
devashishdxt
approved these changes
Jan 20, 2020
lezzokafka
approved these changes
Jan 20, 2020
Codecov Report
@@ Coverage Diff @@
## master #931 +/- ##
==========================================
- Coverage 68.32% 68.31% -0.01%
==========================================
Files 133 133
Lines 17534 17534
==========================================
- Hits 11980 11979 -1
- Misses 5554 5555 +1
|
calvinaco
approved these changes
Jan 20, 2020
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jan 20, 2020
931: Problem(fix #882):required tx-query environment vaiables are unchecked r=tomtau a=linfeng-crypto Solution: add environment check when the tx-query app starts, remove the environment check in the docker run script. Co-authored-by: linfeng <[email protected]>
leejw51crypto
approved these changes
Jan 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution: add environment check when the tx-query app starts, remove the environment check in the docker run script.