Skip to content
This repository has been archived by the owner on Jul 27, 2022. It is now read-only.

Problem: Ambiguous outputs from client-cli #959

Merged
merged 1 commit into from
Jan 22, 2020
Merged

Problem: Ambiguous outputs from client-cli #959

merged 1 commit into from
Jan 22, 2020

Conversation

devashishdxt
Copy link
Collaborator

@devashishdxt devashishdxt commented Jan 22, 2020 •
edited
Loading

Solution: Fixed all the issues described in #951. Fixes #951

tomtau
tomtau approved these changes Jan 22, 2020
View reviewed changes
Copy link
Contributor

@tomtau tomtau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@codecov
Copy link

codecov bot commented Jan 22, 2020 •
edited
Loading

Codecov Report

Merging #959 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #959      +/-   ##
==========================================
- Coverage   67.31%   67.29%   -0.02%     
==========================================
  Files         137      137              
  Lines       18046    18051       +5     
==========================================
  Hits        12148    12148              
- Misses       5898     5903       +5
Impacted Files Coverage Δ
client-cli/src/command/transaction_command.rs 0% <0%> (ø) ⬆️
client-cli/src/command/wallet_command.rs 0% <0%> (ø) ⬆️
client-cli/src/command/address_command.rs 0% <0%> (ø) ⬆️
client-cli/src/command.rs 0% <0%> (ø) ⬆️

@devashishdxt
Copy link
Collaborator Author

bors r+

bors bot added a commit that referenced this pull request Jan 22, 2020
@bors @devashishdxt
Merge #959
b644a38 
959: Problem: Ambiguous outputs from client-cli r=devashishdxt a=devashishdxt

Solution: Fixed all the issues described in #951. Fixes #951 

Co-authored-by: Devashish Dixit <[email protected]>
@bors
Copy link
Contributor

bors bot commented Jan 22, 2020

Build failed

@yihuang
Copy link
Collaborator

yihuang commented Jan 22, 2020 •
edited
Loading

The enum values have capitalized initial character before, I think better to keep it backward compatible, or we need to change many integration tests code.

@devashishdxt
Copy link
Collaborator Author

The enum values have capitalized initial character before, I think better to keep it backward compatible, or we need to change many integration tests code.

It is case insensitive. I think I also need to add case_insensitive option in structopt macro.

@devashishdxt
Copy link
Collaborator Author

bors try

bors bot added a commit that referenced this pull request Jan 22, 2020
@bors
Try #959:
24be8b6
@bors
Copy link
Contributor

bors bot commented Jan 22, 2020

try

Build failed

@devashishdxt
Problem: Ambiguous outputs from client-cli
027b6a3 
Solution: Fixed all the issues described in #951
@devashishdxt
Copy link
Collaborator Author

bors try

bors bot added a commit that referenced this pull request Jan 22, 2020
@bors
Try #959:
8e2dbf5
@bors
Copy link
Contributor

bors bot commented Jan 22, 2020

try

Build succeeded

@devashishdxt
Copy link
Collaborator Author

bors r+

bors bot added a commit that referenced this pull request Jan 22, 2020
@bors @devashishdxt
Merge #959
6fe7a73 
959: Problem: Ambiguous outputs from client-cli r=devashishdxt a=devashishdxt

Solution: Fixed all the issues described in #951. Fixes #951 

Co-authored-by: Devashish Dixit <[email protected]>
@bors
Copy link
Contributor

bors bot commented Jan 22, 2020

Build succeeded

@bors bors bot merged commit 027b6a3 into crypto-com:master Jan 22, 2020
@devashishdxt devashishdxt deleted the fix/issue-951 branch January 23, 2020 09:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yihuang yihuang yihuang approved these changes

@tomtau tomtau tomtau approved these changes

@foreseaz foreseaz Awaiting requested review from foreseaz

@calvinaco calvinaco Awaiting requested review from calvinaco calvinaco is a code owner

@leejw51crypto leejw51crypto Awaiting requested review from leejw51crypto

@lezzokafka lezzokafka Awaiting requested review from lezzokafka

@linfeng-crypto linfeng-crypto Awaiting requested review from linfeng-crypto

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problem: Ambiguous outputs from the client-cli
3 participants
@devashishdxt @yihuang @tomtau