Compiler bug when a macro uses run() with spaces in the path

[obskyr]

Try the following examples, lifted more or less straight from the docs:

directory with spaces/print_gotten_string.cr:

macro get_version
    {{ run("./get_string").stringify }}
end

puts get_version

directory with spaces/get_string.cr:

puts "Hi!"

Running crystal run print_gotten_string.cr errors out with the following message:

can't specify arguments in both, command and args without including "${@}" into your command
???
???
???
???
???
???
???
???
???
???
???
???
???
???
???
???
???
???
???
???
???

Error: you've found a bug in the Crystal compiler. Please open an issue, including source code that will allow us to reproduce the bug: https://github.com/crystal-lang/crystal/issues

It looks like Process.prepare_argv is getting the parts of the path as arguments instead of the entire path being passed in as the command.

[obskyr]

Changed title to reflect the fact that it doesn't error out gracefully.

[asterite]

Should have been fixed by #5543 , but probably not released in some of the past releases because of GitFlow.

[straight-shoota]

There has only been the release of 0.24.2 since the merge and that did only include some bugfixes but not #5543

But I can confirm this issue is fixed in master.

[obskyr]

Terrific, thanks!