Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State of OCM in reva #2942

Closed
ishank011 opened this issue Jun 9, 2022 · 5 comments
Closed

State of OCM in reva #2942

ishank011 opened this issue Jun 9, 2022 · 5 comments
Assignees
Labels

Comments

@ishank011
Copy link
Contributor

No description provided.

@redblom
Copy link
Contributor

redblom commented Jun 20, 2022

Currently a second OCM share (from another user) overrides the OCM share from the first user when both shares use the same folder structure (name clash). The resulting mount paths will be the same.
This applies to data transfer type OCM shares as well.
Note that there is an unimplemented case in the UpdateReceivedOCMShare method that seems relevant here.

@ishank011 Is this something to be resolved/discussed with this here issue, or somewhere else?

@phil-davis
Copy link
Contributor

Note: I think that this issue is related - owncloud/ocis#3880 and not actually fixed/resolved.

There is "trouble" if 2 users create a file with the same name (and usually it will have different content). They both share the file with user3. user3 receives 2 incoming shares that have the same naming, and has trouble to distinguish them and to fetch/get the content of each.

@redblom
Copy link
Contributor

redblom commented Jun 20, 2022

Yes, seems definitely related.
Based on the current code I can only guess what the original idea (if any) was on how to deal with this.

The actual precise mechanism of how to deal with name clashes needs to be defined first.

@ishank011
Copy link
Contributor Author

@redblom @phil-davis we're planning on getting rid of the implementation that brings about this issue in the first place, as part of the GSoC project

@redblom
Copy link
Contributor

redblom commented Jul 13, 2022

Some requirements:

  • ocmshareprovider.UpdateReceivedOCMShare should be implemented for all fields (state, name (mount_point basically is share.Name), etc)
  • The name clash issue (overriding existing shares) should be prevented in the first place, when accepting the share, by creating a unique mount_point. Eg. based on a timestamp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants